ash/common/shelf/shelf_model_unittest.cc - Issue 2171813004: mash: Fold ShelfItemDelegateManager into ShelfModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/shelf/shelf_model_unittest.cc

Issue 2171813004: mash: Fold ShelfItemDelegateManager into ShelfModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: explicitly destroy ShelfItemDelegates Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/common/shelf/shelf_model_unittest.cc

diff --git a/ash/common/shelf/shelf_model_unittest.cc b/ash/common/shelf/shelf_model_unittest.cc

index 209070d14b81de0613287d98508cee9083a9ca92..e0b8bccff0142c0d14be1b0e88f0c4141e522743 100644

--- a/ash/common/shelf/shelf_model_unittest.cc

+++ b/ash/common/shelf/shelf_model_unittest.cc

@@ -45,6 +45,8 @@ class TestShelfModelObserver : public ShelfModelObserver {

void ShelfItemMoved(int start_index, int target_index) override {

moved_count_++;

}

+ void OnSetShelfItemDelegate(ShelfID id,

+ ShelfItemDelegate* item_delegate) override {}

private:

void AddToResult(const std::string& format, int count, std::string* result) {

« no previous file with comments | « ash/common/shelf/shelf_model_observer.h ('k') | ash/common/wm_shell.cc » ('j') | no next file with comments »