Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: ash/common/shelf/shelf_model_observer.h

Issue 2171813004: mash: Fold ShelfItemDelegateManager into ShelfModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: explicitly destroy ShelfItemDelegates Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/common/shelf/shelf_model.cc ('k') | ash/common/shelf/shelf_model_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_SHELF_SHELF_MODEL_OBSERVER_H_ 5 #ifndef ASH_COMMON_SHELF_SHELF_MODEL_OBSERVER_H_
6 #define ASH_COMMON_SHELF_SHELF_MODEL_OBSERVER_H_ 6 #define ASH_COMMON_SHELF_SHELF_MODEL_OBSERVER_H_
7 7
8 #include "ash/ash_export.h" 8 #include "ash/ash_export.h"
9 #include "ash/common/shelf/shelf_item_types.h" 9 #include "ash/common/shelf/shelf_item_types.h"
10 10
11 namespace ash { 11 namespace ash {
12 12
13 struct ShelfItem; 13 struct ShelfItem;
14 class ShelfItemDelegate;
14 15
15 class ASH_EXPORT ShelfModelObserver { 16 class ASH_EXPORT ShelfModelObserver {
16 public: 17 public:
17 // Invoked after an item has been added to the model. 18 // Invoked after an item has been added to the model.
18 virtual void ShelfItemAdded(int index) = 0; 19 virtual void ShelfItemAdded(int index) = 0;
19 20
20 // Invoked after an item has been removed. |index| is the index the item was 21 // Invoked after an item has been removed. |index| is the index the item was
21 // at. 22 // at.
22 virtual void ShelfItemRemoved(int index, ShelfID id) = 0; 23 virtual void ShelfItemRemoved(int index, ShelfID id) = 0;
23 24
24 // Invoked after an item has been moved. See ShelfModel::Move() for details 25 // Invoked after an item has been moved. See ShelfModel::Move() for details
25 // of the arguments. 26 // of the arguments.
26 virtual void ShelfItemMoved(int start_index, int target_index) = 0; 27 virtual void ShelfItemMoved(int start_index, int target_index) = 0;
27 28
28 // Invoked when the state of an item changes. |old_item| is the item 29 // Invoked when the state of an item changes. |old_item| is the item
29 // before the change. 30 // before the change.
30 virtual void ShelfItemChanged(int index, const ShelfItem& old_item) = 0; 31 virtual void ShelfItemChanged(int index, const ShelfItem& old_item) = 0;
31 32
33 // Gets called when a ShelfItemDelegate gets changed. Note that
34 // |item_delegate| can be null.
35 // NOTE: This is added a temporary fix for M39 to fix crbug.com/429870.
36 // TODO(skuhne): Find the real reason for this problem and remove this fix.
37 virtual void OnSetShelfItemDelegate(ShelfID id,
38 ShelfItemDelegate* item_delegate) = 0;
39
32 protected: 40 protected:
33 virtual ~ShelfModelObserver() {} 41 virtual ~ShelfModelObserver() {}
34 }; 42 };
35 43
36 } // namespace ash 44 } // namespace ash
37 45
38 #endif // ASH_COMMON_SHELF_SHELF_MODEL_OBSERVER_H_ 46 #endif // ASH_COMMON_SHELF_SHELF_MODEL_OBSERVER_H_
OLDNEW
« no previous file with comments | « ash/common/shelf/shelf_model.cc ('k') | ash/common/shelf/shelf_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698