Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2171813002: Better performance for -LayoutUnit (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
pdr., esprehn, eae
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Better performance for -LayoutUnit BUG=629932 Committed: https://crrev.com/224e6490115e915ed5e6bc72a7a0bafe32d29389 Cr-Commit-Position: refs/heads/master@{#406913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M third_party/WebKit/Source/platform/LayoutUnit.h View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/SaturatedArithmetic.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/asm/SaturatedArithmeticARM.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Xianzhu
4 years, 5 months ago (2016-07-21 16:55:45 UTC) #3
esprehn
lgtm
4 years, 5 months ago (2016-07-21 17:30:02 UTC) #5
pdr.
On 2016/07/21 at 17:30:02, esprehn wrote: > lgtm LGTM here as well.
4 years, 5 months ago (2016-07-21 17:37:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171813002/1
4 years, 5 months ago (2016-07-21 18:29:25 UTC) #10
esprehn
eae@ FYI
4 years, 5 months ago (2016-07-21 18:32:06 UTC) #12
eae
LGTM This is awesome. I've been meaning to do a QADD/QSUB optimization for arm for ...
4 years, 5 months ago (2016-07-21 18:34:18 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 18:35:31 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 18:37:31 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/224e6490115e915ed5e6bc72a7a0bafe32d29389
Cr-Commit-Position: refs/heads/master@{#406913}

Powered by Google App Engine
This is Rietveld 408576698