Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2171793002: Remove unused include_dir in //ui/event/BUILD.gn (Closed)

Created:
4 years, 5 months ago by tzik
Modified:
4 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gtest_include
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused include_dir in //ui/event/BUILD.gn An include_dir setup for gmock in //ui/event/BUILD.gn is unused, and that prevents to add another include dir to gmock dependencies. This CL removes it for the preparation. BUG=630299 Committed: https://crrev.com/10dbcfdfe239cdc2356dbe484f22b64e25b50d78 Cr-Commit-Position: refs/heads/master@{#406909}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ui/events/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tzik
PTAL
4 years, 5 months ago (2016-07-21 16:12:29 UTC) #5
sadrul
lgtm
4 years, 5 months ago (2016-07-21 16:51:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171793002/20001
4 years, 5 months ago (2016-07-21 18:18:23 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 18:24:08 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 18:27:37 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/10dbcfdfe239cdc2356dbe484f22b64e25b50d78
Cr-Commit-Position: refs/heads/master@{#406909}

Powered by Google App Engine
This is Rietveld 408576698