blink_downstream: prepare for remote_run conversion

scripts/slave/recipes/blink_downstream.py

Index: scripts/slave/recipes/blink_downstream.py
diff --git a/scripts/slave/recipes/blink_downstream.py b/scripts/slave/recipes/blink_downstream.py
index 2c137c26ae26bb93fefb6bdfb9c41120ee62a2b0..120902def016b455be50492d810f412fd0441d32 100644
--- a/scripts/slave/recipes/blink_downstream.py
+++ b/scripts/slave/recipes/blink_downstream.py
@@ -131,50 +131,56 @@ def RunSteps(api):
   # Ensure we remember the chromium revision.
   api.gclient.c.got_revision_mapping['src'] = 'got_cr_revision'
 
-  step_result = api.bot_update.ensure_checkout(force=True)
+  context = {}
+  checkout_dir = api.chromium_tests.get_checkout_dir(bot_config)
+  if checkout_dir:
+    context['cwd'] = checkout_dir
 
-  api.chromium.c.project_generator.tool = 'mb'
-  api.chromium.runhooks()
+  with api.step.context(context):

[Sergiy Byelozyorov, 2016/07/21 12:00:24]

please explain in description why this context is necessary

[Paweł Hajdan Jr., 2016/07/21 13:53:05]

Done.

+    step_result = api.bot_update.ensure_checkout(force=True)
 
-  api.chromium_tests.run_mb_and_compile(
-      ['blink_tests'], [],
-      name_suffix=' (with patch)',
-  )
-
-  api.chromium.runtest('webkit_unit_tests', xvfb=True)
-
-  def component_pinned_fn(_failing_steps):
-    bot_update_json = step_result.json.output
-    api.gclient.c.revisions['src'] = str(
-        bot_update_json['properties']['got_cr_revision'])
-    # Reset component revision to the pinned revision from chromium's DEPS
-    # for comparison.
-    del api.gclient.c.revisions[bot_config['component']['path']]
-    # Update without changing got_revision. The first sync is the revision
-    # that is tested. The second is just for comparison. Setting got_revision
-    # again confuses the waterfall's console view.
-    api.bot_update.ensure_checkout(force=True, update_presentation=False)
+    api.chromium.c.project_generator.tool = 'mb'
+    api.chromium.runhooks()
 
     api.chromium_tests.run_mb_and_compile(
         ['blink_tests'], [],
-        name_suffix=' (without patch)',
+        name_suffix=' (with patch)',
     )
 
-  extra_args = list(bot_config.get('test_args', []))
-  if bot_config.get('additional_expectations'):
-    extra_args.extend([
-      '--additional-expectations',
-      api.path['checkout'].join(*bot_config['additional_expectations']),
-    ])
-
-  tests = [
-    api.chromium_tests.steps.BlinkTest(extra_args=extra_args),
-  ]
-
-  if 'ignition' in buildername:
-    determine_new_ignition_failures(api, extra_args)
-  else:
-    api.test_utils.determine_new_failures(api, tests, component_pinned_fn)
+    api.chromium.runtest('webkit_unit_tests', xvfb=True)
+
+    def component_pinned_fn(_failing_steps):
+      bot_update_json = step_result.json.output
+      api.gclient.c.revisions['src'] = str(
+          bot_update_json['properties']['got_cr_revision'])
+      # Reset component revision to the pinned revision from chromium's DEPS
+      # for comparison.
+      del api.gclient.c.revisions[bot_config['component']['path']]
+      # Update without changing got_revision. The first sync is the revision
+      # that is tested. The second is just for comparison. Setting got_revision
+      # again confuses the waterfall's console view.
+      api.bot_update.ensure_checkout(force=True, update_presentation=False)
+
+      api.chromium_tests.run_mb_and_compile(
+          ['blink_tests'], [],
+          name_suffix=' (without patch)',
+      )
+
+    extra_args = list(bot_config.get('test_args', []))
+    if bot_config.get('additional_expectations'):
+      extra_args.extend([
+        '--additional-expectations',
+        api.path['checkout'].join(*bot_config['additional_expectations']),
+      ])
+
+    tests = [
+      api.chromium_tests.steps.BlinkTest(extra_args=extra_args),
+    ]
+
+    if 'ignition' in buildername:
+      determine_new_ignition_failures(api, extra_args)
+    else:
+      api.test_utils.determine_new_failures(api, tests, component_pinned_fn)
 
 
 def _sanitize_nonalpha(text):
@@ -190,7 +196,8 @@ def GenTests(api):
     return (
       api.properties.generic(mastername=mastername,
                              buildername=buildername,
-                             revision='20123')
+                             revision='20123',
+                             path_config='kitchen')
     )
 
   for mastername, master_config in BUILDERS.iteritems():