Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2171723002: [turbofan] Remove unused function_type_ from Typer. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove unused function_type_ from Typer. This is never passed to the Typer, and actually wouldn't work anyways, since we cannot derive any meaningful types for Parameters in JavaScript. R=mstarzinger@chromium.org Committed: https://crrev.com/1b004d3f9d7720846272e18d3deff73640a48534 Cr-Commit-Position: refs/heads/master@{#37944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M src/compiler/typer.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-21 11:17:56 UTC) #1
Michael Starzinger
LGTM. Love it!
4 years, 5 months ago (2016-07-21 11:19:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171723002/1
4 years, 5 months ago (2016-07-21 11:19:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 11:39:53 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 11:42:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b004d3f9d7720846272e18d3deff73640a48534
Cr-Commit-Position: refs/heads/master@{#37944}

Powered by Google App Engine
This is Rietveld 408576698