[system health] Make mobile washington post story more robust.

[system health] Make mobile washington post story more robust.

This patch makes sure that we wait for either the "Close" or
the "Send link to phone" button after loading the document.

BUG=629983
Committed: https://crrev.com/10766908401f0dd9631b670aa252c33473c41f67
Cr-Commit-Position: refs/heads/master@{#406816}

[ulan, 2016-07-21 09:40:00]

ulan@chromium.org changed reviewers:
+ petrcermak@chromium.org

[ulan, 2016-07-21 09:40:00]

PTAL. This is speculative fix for crbug.com/629983.

[petrcermak, 2016-07-21 09:49:13]

LGTM with one comment. Also I'd make the description slightly more precise:

* s/element/either the "Close" or the "Send link to phone" button/
* s/before clicking it/after loading the document/ (we don't always click)

Thanks,
Petr

https://codereview.chromium.org/2171713003/diff/40001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/browsing_stories.py (right):

https://codereview.chromium.org/2171713003/diff/40001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/browsing_stories.py:214: else:
Given that you have waited for the element, I don't think you need to assert
this anymore ;-)

https://codereview.chromium.org/2171713003/diff/40001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/loading_stories.py (right):

https://codereview.chromium.org/2171713003/diff/40001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/loading_stories.py:194: else:
ditto

[ulan, 2016-07-21 09:52:01]

Description was changed from

==========
[system health] Make mobile washington post story more robust.

This patch makes sure that we wait for element before clicking it.

BUG=629983
==========

to

==========
[system health] Make mobile washington post story more robust.

This patch makes sure that we wait for either the "Close" or
the "Send link to phone" button after loading the document.

BUG=629983
==========

[ulan, 2016-07-21 09:53:25]

Thanks, landing.

https://codereview.chromium.org/2171713003/diff/40001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/browsing_stories.py (right):

https://codereview.chromium.org/2171713003/diff/40001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/browsing_stories.py:214: else:
On 2016/07/21 09:49:13, petrcermak wrote:
> Given that you have waited for the element, I don't think you need to assert
> this anymore ;-)

Done.

https://codereview.chromium.org/2171713003/diff/40001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/loading_stories.py (right):

https://codereview.chromium.org/2171713003/diff/40001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/loading_stories.py:194: else:
On 2016/07/21 09:49:13, petrcermak wrote:
> ditto

Done.

[ulan, 2016-07-21 09:54:00]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-07-21 09:54:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/2171713003/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-07-21 09:54:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 10:49:06]

Description was changed from

==========
[system health] Make mobile washington post story more robust.

This patch makes sure that we wait for either the "Close" or
the "Send link to phone" button after loading the document.

BUG=629983
==========

to

==========
[system health] Make mobile washington post story more robust.

This patch makes sure that we wait for either the "Close" or
the "Send link to phone" button after loading the document.

BUG=629983
==========

[commit-bot: I haz the power, 2016-07-21 10:49:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-21 10:50:35]

Description was changed from

==========
[system health] Make mobile washington post story more robust.

This patch makes sure that we wait for either the "Close" or
the "Send link to phone" button after loading the document.

BUG=629983
==========

to

==========
[system health] Make mobile washington post story more robust.

This patch makes sure that we wait for either the "Close" or
the "Send link to phone" button after loading the document.

BUG=629983

Committed: https://crrev.com/10766908401f0dd9631b670aa252c33473c41f67
Cr-Commit-Position: refs/heads/master@{#406816}
==========

[commit-bot: I haz the power, 2016-07-21 10:50:37]

Patchset 4 (id:??) landed as
https://crrev.com/10766908401f0dd9631b670aa252c33473c41f67
Cr-Commit-Position: refs/heads/master@{#406816}

[petrcermak, 2016-07-22 11:25:52]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2172153004/ by petrcermak@chromium.org.

The reason for reverting is: It broke Android perf bots..