Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1699)

Unified Diff: chrome/browser/content_settings/tab_specific_content_settings.h

Issue 2171713002: Safe browsing subresource filter bubble UI skeleton. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: xib with osx 10.9 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/tab_specific_content_settings.h
diff --git a/chrome/browser/content_settings/tab_specific_content_settings.h b/chrome/browser/content_settings/tab_specific_content_settings.h
index dc20cd102122327bfc9bba8173c947eaabe916de..ea23fb4803b7225093b22dc0c7c3af33b55b169c 100644
--- a/chrome/browser/content_settings/tab_specific_content_settings.h
+++ b/chrome/browser/content_settings/tab_specific_content_settings.h
@@ -188,6 +188,10 @@ class TabSpecificContentSettings
void SetBlockageHasBeenIndicated(ContentSettingsType content_type);
+ void SetSubresourceBlockageIndicated() {
msramek 2016/07/27 09:46:21 Please define in this in the .cc file like above.
melandory 2016/07/27 12:53:40 Done.
+ is_subresource_filter_blockage_indicated_ = true;
+ }
+
// Returns whether a particular kind of content has been allowed. Currently
// only tracks cookies.
bool IsContentAllowed(ContentSettingsType content_type) const;
@@ -240,6 +244,14 @@ class TabSpecificContentSettings
return midi_usages_state_;
}
+ bool is_subresource_filter_enabled() const {
msramek 2016/07/27 09:46:21 Please make it more obvious that this supplements
melandory 2016/07/27 12:53:40 Done.
+ return is_subresource_filter_enabled_;
+ }
+
+ void set_is_subresource_filter_enabled(bool enabled) {
msramek 2016/07/27 09:46:21 Please make this consistent with SetDownloadsBlock
melandory 2016/07/27 12:53:40 Done.
+ is_subresource_filter_enabled_ = enabled;
+ }
+
// Call to indicate that there is a protocol handler pending user approval.
void set_pending_protocol_handler(const ProtocolHandler& handler) {
pending_protocol_handler_ = handler;
@@ -467,6 +479,10 @@ class TabSpecificContentSettings
std::string media_stream_requested_audio_device_;
std::string media_stream_requested_video_device_;
+ // Manages information about Subresource filtering activation.
+ bool is_subresource_filter_enabled_;
msramek 2016/07/27 09:46:21 nit: the "is" seems superfluous
melandory 2016/07/27 12:53:40 Done.
+ bool is_subresource_filter_blockage_indicated_;
+
// Observer to watch for content settings changed.
ScopedObserver<HostContentSettingsMap, content_settings::Observer> observer_;

Powered by Google App Engine
This is Rietveld 408576698