Safe browsing subresource filter bubble UI skeleton.

chrome/browser/ui/content_settings/content_setting_image_model.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_CONTENT_SETTINGS_CONTENT_SETTING_IMAGE_MODEL_H_
 #define CHROME_BROWSER_UI_CONTENT_SETTINGS_CONTENT_SETTING_IMAGE_MODEL_H_
 
 #include "base/macros.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/string16.h"
@@ skipping 47 matching lines @@
       content::WebContents* web_contents);
 #endif
 
   gfx::Image GetIcon(SkColor nearby_text_color) const;
 
   // Returns the resource ID of a string to show when the icon appears, or 0 if
   // we don't wish to show anything.
   int explanatory_string_id() const { return explanatory_string_id_; }
   const base::string16& get_tooltip() const { return tooltip_; }
 
+  static std::unique_ptr<ContentSettingImageModel>
+  CreateSubresourceFilterImageModelForTesting();

[msramek, 2016/07/27 09:46:22]

I think this fundamentally doesn't belong here. We should probably pull out the
class declaration here to the .cc file, same way as we did for
ContentSettingSimpleImageModel.

Basically, we could get away with hiding most class declarations in the .cc file
because ContentSettingSimpleImageModel knows how to construct them from
ContentSettingsType, but that's not possible here. So I believe your class
declaration should be public in the .h file.

[melandory, 2016/07/27 12:53:41]

Done.

+
  protected:
   ContentSettingImageModel();
   void SetIconByResourceId(int id);
 
   void set_icon_by_vector_id(gfx::VectorIconId id, gfx::VectorIconId badge_id) {
     vector_icon_id_ = id;
     vector_icon_badge_id_ = badge_id;
   }
 
   void set_visible(bool visible) { is_visible_ = visible; }
@@ skipping 38 matching lines @@
  protected:
   ContentSettingsType content_type() { return content_type_; }
 
  private:
   ContentSettingsType content_type_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentSettingSimpleImageModel);
 };
 
 #endif  // CHROME_BROWSER_UI_CONTENT_SETTINGS_CONTENT_SETTING_IMAGE_MODEL_H_