Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2171703005: Remove unneeded dependency from webapk/shell_apk on webapk/libs/runtime_library (Closed)

Created:
4 years, 5 months ago by pkotwicz
Modified:
4 years, 5 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded dependency from webapk/shell_apk on webapk/libs/runtime_library BUG=None Committed: https://crrev.com/c3f5e2f26388fa1d5af28c9bd00673b9fd9d9f9c Cr-Commit-Position: refs/heads/master@{#407327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/android/webapk/shell_apk/DEPS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
pkotwicz
Yaron can you please take a look?
4 years, 5 months ago (2016-07-21 20:48:30 UTC) #2
Yaron
lgtm
4 years, 5 months ago (2016-07-22 13:26:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171703005/1
4 years, 5 months ago (2016-07-23 00:12:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-23 01:11:02 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 01:14:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3f5e2f26388fa1d5af28c9bd00673b9fd9d9f9c
Cr-Commit-Position: refs/heads/master@{#407327}

Powered by Google App Engine
This is Rietveld 408576698