Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: src/parsing/parameter-initializer-rewriter.h

Issue 2171703004: Rescope arrow-function parameter lists by moving the delta to the parameter scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove unnecessary DCHECK Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/scopes.cc ('k') | src/parsing/parameter-initializer-rewriter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parameter-initializer-rewriter.h
diff --git a/src/parsing/parameter-initializer-rewriter.h b/src/parsing/parameter-initializer-rewriter.h
index 255534c99e73a6cdc26a425ea5cc3f28235259b4..65c3a3c7ead421907e842914c0814f9604bd315a 100644
--- a/src/parsing/parameter-initializer-rewriter.h
+++ b/src/parsing/parameter-initializer-rewriter.h
@@ -10,11 +10,15 @@
namespace v8 {
namespace internal {
-
-void RewriteParameterInitializerScope(uintptr_t stack_limit,
- Expression* initializer, Scope* old_scope,
- Scope* new_scope);
-
+// When an extra declaration scope needs to be inserted to account for
+// a sloppy eval in a default parameter or function body, the expressions
+// needs to be in that new inner scope which was added after initial
+// parsing.
+//
+// param_scope is the new inner scope, and its outer_scope() is assumed
+// to be the function scope which was used during the initial parse.
+void ReparentParameterExpressionScope(uintptr_t stack_limit, Expression* expr,
+ Scope* param_scope);
} // namespace internal
} // namespace v8
« no previous file with comments | « src/ast/scopes.cc ('k') | src/parsing/parameter-initializer-rewriter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698