Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2171703002: [turbofan] Sanitize the Truncation query method names. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_SimplifiedLowering_TruncationNone
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Sanitize the Truncation query method names. Use better names for the query methods on the Truncation class, that express more clearly what you intend to query. R=jarin@chromium.org Committed: https://crrev.com/a04467f9e37c708e982e626dd00e7235e693402c Cr-Commit-Position: refs/heads/master@{#37935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -43 lines) Patch
M src/compiler/representation-change.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/representation-change.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 27 chunks +31 lines, -31 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-21 08:20:59 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-07-21 08:24:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171703002/1
4 years, 5 months ago (2016-07-21 09:10:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 09:38:06 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 09:40:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a04467f9e37c708e982e626dd00e7235e693402c
Cr-Commit-Position: refs/heads/master@{#37935}

Powered by Google App Engine
This is Rietveld 408576698