Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 2171663002: Revert of Roll gtest. (Closed)

Created:
4 years, 5 months ago by piman
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll gtest. (patchset #7 id:120001 of https://codereview.chromium.org/2163573002/ ) Reason for revert: Looks like this broke gyp: https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/892 https://build.chromium.org/p/chromium.mac/builders/Mac%20GYP%20%28dbg%29/builds/1249 The issue seems non-trivial to fix (may need an angle roll), so reverting. Original issue's description: > Roll gtest. > > The change in directory structure requires the checkout to be moved to > a different directory, and some dummy header files that re-direct to the > new location. > > TBR=juliatuttle@chromium.org > > Committed: https://crrev.com/4266a7d49d60d3af744bfb513cbdeb716b0b6782 > Cr-Commit-Position: refs/heads/master@{#406741} TBR=phajdan.jr@chromium.org,agrieve@chromium.org,juliatuttle@chromium.org,amistry@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5623da4313d457a675edb33dd2b9612d1bcdac66 Cr-Commit-Position: refs/heads/master@{#406745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -317 lines) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
A build/secondary/testing/gtest/BUILD.gn View 1 chunk +160 lines, -0 lines 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/gtest.gyp View 4 chunks +4 lines, -5 lines 0 comments Download
M testing/gtest.gypi View 1 chunk +8 lines, -28 lines 0 comments Download
D testing/gtest/BUILD.gn View 1 chunk +0 lines, -165 lines 0 comments Download
D testing/gtest/include/gtest/gtest.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/gtest-death-test.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/gtest-message.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/gtest-param-test.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/gtest-printers.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/gtest-spi.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/gtest-test-part.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/gtest-typed-test.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/gtest_pred_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/gtest_prod.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/internal/gtest-death-test-internal.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/internal/gtest-filepath.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/internal/gtest-internal.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/internal/gtest-linked_ptr.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/internal/gtest-param-util.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/internal/gtest-param-util-generated.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/internal/gtest-port.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/internal/gtest-port-arch.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/internal/gtest-string.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/internal/gtest-tuple.h View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/gtest/include/gtest/internal/gtest-type-util.h View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/gtest_nacl.gyp View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/licenses.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
piman
Created Revert of Roll gtest.
4 years, 5 months ago (2016-07-21 03:01:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171663002/1
4 years, 5 months ago (2016-07-21 03:02:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 03:03:31 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 03:05:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5623da4313d457a675edb33dd2b9612d1bcdac66
Cr-Commit-Position: refs/heads/master@{#406745}

Powered by Google App Engine
This is Rietveld 408576698