Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2171653002: DevTools: fix computed style pane layout (Closed)

Created:
4 years, 5 months ago by lushnikov
Modified:
4 years, 5 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix computed style pane layout Both computed section and platform fonts should not be shrinkable. BUG=none TBR=pfeldman Committed: https://crrev.com/acb64bfdfccac34409ffccd954597992bcd71123 Cr-Commit-Position: refs/heads/master@{#406760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/computedStyleSidebarPane.css View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/platformFontsWidget.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
lushnikov
That's what a bad layout look like on TOT: http://imgur.com/a/Bdeph
4 years, 5 months ago (2016-07-21 02:25:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171653002/1
4 years, 5 months ago (2016-07-21 02:25:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 03:38:49 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 03:42:04 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/acb64bfdfccac34409ffccd954597992bcd71123
Cr-Commit-Position: refs/heads/master@{#406760}

Powered by Google App Engine
This is Rietveld 408576698