Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: pkg/code_transformers/test/resolver_test.dart

Issue 217163005: Code transformers fixes for latest analyzer update (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: bumping version Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/code_transformers/pubspec.yaml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/code_transformers/test/resolver_test.dart
diff --git a/pkg/code_transformers/test/resolver_test.dart b/pkg/code_transformers/test/resolver_test.dart
index 9863d7ea1bf28ef1257a72d6d0d6305f721558f9..7a1a34c33ce4eaae6f227f33d9cfdef3f05f5098 100644
--- a/pkg/code_transformers/test/resolver_test.dart
+++ b/pkg/code_transformers/test/resolver_test.dart
@@ -17,7 +17,7 @@ main() {
var entryPoint = new AssetId('a', 'web/main.dart');
var resolvers = new Resolvers(testingDartSdkDirectory);
- Future validateResolver({Map<String, String> inputs, void validator(Resolver),
+ Future validateResolver({Map<String, String> inputs, validator(Resolver),
List<String> messages: const[]}) {
return applyTransformers(
[[new TestTransformer(resolvers, entryPoint, validator)]],
@@ -118,15 +118,30 @@ main() {
});
});
+ test('handles missing files', () {
+ return validateResolver(
+ inputs: {
+ 'a|web/main.dart': '''
+ import 'package:b/missing.dart';
+
+ main() {
+ } ''',
+ },
+ validator: (resolver) {
+ var lib = resolver.getLibrary(entryPoint);
+ expect(lib.importedLibraries.length, 1);
+ });
+ });
+
test('should update on changed package imports', () {
return validateResolver(
inputs: {
'a|web/main.dart': '''
- import 'package:b/b.dart';
+ import 'package:b/missing.dart';
main() {
} ''',
- 'b|lib/b.dart': '''
+ 'b|lib/missing.dart': '''
library b;
class Bar {}
''',
@@ -143,14 +158,11 @@ main() {
return validateResolver(
inputs: {
'a|web/main.dart': '''
- import 'package:b/b.dart';
+ import 'package:b/missing.dart';
main() {
} ''',
},
- messages: [
- 'error: Unable to find asset for "package:b/b.dart"',
- ],
validator: (resolver) {
var lib = resolver.getLibrary(entryPoint);
expect(lib.importedLibraries.length, 1);
@@ -169,8 +181,8 @@ main() {
messages: [
// First from the AST walker
'error: absolute paths not allowed: "/b.dart" (web/main.dart 0 14)',
- // Then two from the resolver.
'error: absolute paths not allowed: "/b.dart"',
+ // TODO: remove this when analyzer is updated.
'error: absolute paths not allowed: "/b.dart"',
],
validator: (resolver) {
@@ -346,7 +358,5 @@ class TestTransformer extends Transformer with ResolverTransformer {
Future<bool> isPrimary(Asset input) =>
new Future.value(input.id == primary);
- applyResolver(Transform transform, Resolver resolver) {
- return validator(resolver);
- }
+ applyResolver(Transform transform, Resolver resolver) => validator(resolver);
}
« no previous file with comments | « pkg/code_transformers/pubspec.yaml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698