third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp - Issue 2171563002: Add WorkerSettings to expose certain flag values in WorkerGlobalScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

Issue 2171563002: Add WorkerSettings to expose certain flag values in WorkerGlobalScope (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h ('k') | third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

diff --git a/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp b/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

index ddd9976cf30e1597d4a3d2e2f4a02865adfce20d..2b07694c26fb7b53a52aaed018e6a022b0be2e4f 100644

--- a/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

+++ b/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

@@ -106,9 +106,7 @@ void OffscreenCanvas::registerRenderingContextFactory(std::unique_ptr<CanvasRend

bool OffscreenCanvas::originClean() const

{

- // TODO(crbug.com/607575): Make Settings accessable in worker and use

- // disableReadingFromCanvas to determine originClean value.

- return m_originClean;

+ return m_originClean && !m_disableReadingFromCanvas;

}

DEFINE_TRACE(OffscreenCanvas)