Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: gpu/command_buffer/service/framebuffer_manager_unittest.cc

Issue 2171543002: Split DEPTH_STENCIL into DEPTH and STENCIL in command buffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test bots Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include "gpu/command_buffer/service/error_state_mock.h" 8 #include "gpu/command_buffer/service/error_state_mock.h"
9 #include "gpu/command_buffer/service/feature_info.h" 9 #include "gpu/command_buffer/service/feature_info.h"
10 #include "gpu/command_buffer/service/framebuffer_manager.h" 10 #include "gpu/command_buffer/service/framebuffer_manager.h"
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 const GLsizei kSamples3 = 0; 220 const GLsizei kSamples3 = 0;
221 const GLsizei kWidth4 = 16; 221 const GLsizei kWidth4 = 16;
222 const GLsizei kHeight4 = 32; 222 const GLsizei kHeight4 = 32;
223 const GLenum kFormat4 = GL_STENCIL_INDEX8; 223 const GLenum kFormat4 = GL_STENCIL_INDEX8;
224 const GLsizei kSamples4 = 0; 224 const GLsizei kSamples4 = 0;
225 const GLsizei kDifferentSamples4 = 1; 225 const GLsizei kDifferentSamples4 = 1;
226 226
227 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0)); 227 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0));
228 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_DEPTH_ATTACHMENT)); 228 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_DEPTH_ATTACHMENT));
229 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_STENCIL_ATTACHMENT)); 229 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_STENCIL_ATTACHMENT));
230 EXPECT_FALSE(
231 framebuffer_->HasUnclearedAttachment(GL_DEPTH_STENCIL_ATTACHMENT));
232 230
233 renderbuffer_manager_->CreateRenderbuffer( 231 renderbuffer_manager_->CreateRenderbuffer(
234 kRenderbufferClient1Id, kRenderbufferService1Id); 232 kRenderbufferClient1Id, kRenderbufferService1Id);
235 Renderbuffer* renderbuffer1 = 233 Renderbuffer* renderbuffer1 =
236 renderbuffer_manager_->GetRenderbuffer(kRenderbufferClient1Id); 234 renderbuffer_manager_->GetRenderbuffer(kRenderbufferClient1Id);
237 ASSERT_TRUE(renderbuffer1 != NULL); 235 ASSERT_TRUE(renderbuffer1 != NULL);
238 236
239 // check adding one attachment 237 // check adding one attachment
240 framebuffer_->AttachRenderbuffer(GL_COLOR_ATTACHMENT0, renderbuffer1); 238 framebuffer_->AttachRenderbuffer(GL_COLOR_ATTACHMENT0, renderbuffer1);
241 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0)); 239 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0));
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 const GLenum kTarget2 = GL_TEXTURE_2D; 446 const GLenum kTarget2 = GL_TEXTURE_2D;
449 const GLsizei kSamples2 = 0; 447 const GLsizei kSamples2 = 0;
450 const GLsizei kWidth3 = 75; 448 const GLsizei kWidth3 = 75;
451 const GLsizei kHeight3 = 123; 449 const GLsizei kHeight3 = 123;
452 const GLint kLevel3 = 0; 450 const GLint kLevel3 = 0;
453 const GLenum kFormat3 = GL_RGB565; 451 const GLenum kFormat3 = GL_RGB565;
454 const GLsizei kSamples3 = 0; 452 const GLsizei kSamples3 = 0;
455 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0)); 453 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0));
456 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_DEPTH_ATTACHMENT)); 454 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_DEPTH_ATTACHMENT));
457 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_STENCIL_ATTACHMENT)); 455 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_STENCIL_ATTACHMENT));
458 EXPECT_FALSE(
459 framebuffer_->HasUnclearedAttachment(GL_DEPTH_STENCIL_ATTACHMENT));
460 EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT), 456 EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT),
461 framebuffer_->IsPossiblyComplete(feature_info_.get())); 457 framebuffer_->IsPossiblyComplete(feature_info_.get()));
462 458
463 texture_manager_->CreateTexture(kTextureClient1Id, kTextureService1Id); 459 texture_manager_->CreateTexture(kTextureClient1Id, kTextureService1Id);
464 scoped_refptr<TextureRef> texture1( 460 scoped_refptr<TextureRef> texture1(
465 texture_manager_->GetTexture(kTextureClient1Id)); 461 texture_manager_->GetTexture(kTextureClient1Id));
466 ASSERT_TRUE(texture1.get() != NULL); 462 ASSERT_TRUE(texture1.get() != NULL);
467 463
468 // check adding one attachment 464 // check adding one attachment
469 framebuffer_->AttachTexture( 465 framebuffer_->AttachTexture(
(...skipping 1036 matching lines...) Expand 10 before | Expand all | Expand 10 after
1506 const GLenum kFormat1 = GL_RGBA4; 1502 const GLenum kFormat1 = GL_RGBA4;
1507 const GLsizei kSamples1 = 0; 1503 const GLsizei kSamples1 = 0;
1508 const GLsizei kWidth2 = 32; // Different from kWidth1 1504 const GLsizei kWidth2 = 32; // Different from kWidth1
1509 const GLsizei kHeight2 = 32; 1505 const GLsizei kHeight2 = 32;
1510 const GLenum kFormat2 = GL_DEPTH_COMPONENT16; 1506 const GLenum kFormat2 = GL_DEPTH_COMPONENT16;
1511 const GLsizei kSamples2 = 0; 1507 const GLsizei kSamples2 = 0;
1512 1508
1513 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0)); 1509 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0));
1514 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_DEPTH_ATTACHMENT)); 1510 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_DEPTH_ATTACHMENT));
1515 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_STENCIL_ATTACHMENT)); 1511 EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_STENCIL_ATTACHMENT));
1516 EXPECT_FALSE(
1517 framebuffer_->HasUnclearedAttachment(GL_DEPTH_STENCIL_ATTACHMENT));
1518 1512
1519 renderbuffer_manager_->CreateRenderbuffer( 1513 renderbuffer_manager_->CreateRenderbuffer(
1520 kRenderbufferClient1Id, kRenderbufferService1Id); 1514 kRenderbufferClient1Id, kRenderbufferService1Id);
1521 Renderbuffer* renderbuffer1 = 1515 Renderbuffer* renderbuffer1 =
1522 renderbuffer_manager_->GetRenderbuffer(kRenderbufferClient1Id); 1516 renderbuffer_manager_->GetRenderbuffer(kRenderbufferClient1Id);
1523 ASSERT_TRUE(renderbuffer1 != NULL); 1517 ASSERT_TRUE(renderbuffer1 != NULL);
1524 renderbuffer_manager_->SetInfo( 1518 renderbuffer_manager_->SetInfo(
1525 renderbuffer1, kSamples1, kFormat1, kWidth1, kHeight1); 1519 renderbuffer1, kSamples1, kFormat1, kWidth1, kHeight1);
1526 framebuffer_->AttachRenderbuffer(GL_COLOR_ATTACHMENT0, renderbuffer1); 1520 framebuffer_->AttachRenderbuffer(GL_COLOR_ATTACHMENT0, renderbuffer1);
1527 1521
(...skipping 29 matching lines...) Expand all
1557 renderbuffer_manager_->GetRenderbuffer(kRenderbufferClientId); 1551 renderbuffer_manager_->GetRenderbuffer(kRenderbufferClientId);
1558 ASSERT_TRUE(renderbuffer != NULL); 1552 ASSERT_TRUE(renderbuffer != NULL);
1559 framebuffer_->AttachRenderbuffer(GL_COLOR_ATTACHMENT1, renderbuffer); 1553 framebuffer_->AttachRenderbuffer(GL_COLOR_ATTACHMENT1, renderbuffer);
1560 EXPECT_TRUE(framebuffer_->GetReadBufferAttachment()); 1554 EXPECT_TRUE(framebuffer_->GetReadBufferAttachment());
1561 } 1555 }
1562 1556
1563 } // namespace gles2 1557 } // namespace gles2
1564 } // namespace gpu 1558 } // namespace gpu
1565 1559
1566 1560
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698