chrome/browser/resources/md_history/synced_device_manager.html - Issue 2171513004: MD History: Hide sign in guide in guest mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/synced_device_manager.html

Issue 2171513004: MD History: Hide sign in guide in guest mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add guestSession to arguments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/md_history/synced_device_manager.html

diff --git a/chrome/browser/resources/md_history/synced_device_manager.html b/chrome/browser/resources/md_history/synced_device_manager.html

index b7637ed5c2508d42f1b653c104d65a686258a962..54dc43ff9d34aa7609aee4c8b5d53238ed40b38f 100644

--- a/chrome/browser/resources/md_history/synced_device_manager.html

+++ b/chrome/browser/resources/md_history/synced_device_manager.html

@@ -73,10 +73,11 @@

</template>

</div>

<div id="no-synced-tabs" class="centered-message"

- hidden="[[!showNoSyncedMessage(signInState_, syncedDevices_.length)]]">

+ hidden="[[!showNoSyncedMessage(signInState_, syncedDevices_.length, guestSession_)]]">

tsergeant 2016/07/22 00:14:02 Nit: You can wrap the attribute to avoid having lo

lshang 2016/07/22 01:09:05 Done.

[[noSyncedTabsMessage(fetchingSyncedTabs_)]]

</div>

- <div id="sign-in-guide" hidden$="[[signInState_]]">

+ <div id="sign-in-guide"

+ hidden="[[!showSignInGuide(signInState_, guestSession_)]]">

tsergeant 2016/07/22 00:14:02 Nit: Also indent this by 4 spaces

lshang 2016/07/22 01:09:05 Done.

<div id="sign-in-promo">$i18n{signInPromo}</div>

<div id="sign-in-promo-desc">$i18n{signInPromoDesc}</div>

« no previous file with comments | « no previous file | chrome/browser/resources/md_history/synced_device_manager.js » ('j') | no next file with comments »