MD History: Hide sign in guide in guest mode

chrome/browser/resources/md_history/synced_device_manager.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{device: string,
  *           lastUpdateTime: string,
  *           separatorIndexes: !Array<number>,
  *           timestamp: number,
  *           tabs: !Array<!ForeignSessionTab>,
@@ skipping 27 matching lines @@
       value: function() { return []; }
     },
 
     /** @private */
     signInState_: {
       type: Boolean,
       value: loadTimeData.getBoolean('isUserSignedIn'),
     },
 
     /** @private */
+    guestSession_: {
+      type: Boolean,
+      value: loadTimeData.getBoolean('isGuestSession'),
+    },
+
+    /** @private */
     fetchingSyncedTabs_: {
       type: Boolean,
       value: false,
     }
   },
 
   /**
    * @param {!ForeignSession} session
    * @return {!ForeignDeviceInternal}
    */
@@ skipping 46 matching lines @@
     this.syncedDevices_ = [];
   },
 
   /**
    * Decide whether or not should display no synced tabs message.
    * @param {boolean} signInState
    * @param {number} syncedDevicesLength
    * @return {boolean}
    */
   showNoSyncedMessage: function(signInState, syncedDevicesLength) {
+    if (this.guestSession_)
+      return true;

[calamity, 2016/07/21 04:56:49]

nit: Newline after early return.

[lshang, 2016/07/21 07:09:55]

Done.

     return signInState && syncedDevicesLength == 0;
   },
 
   /**
+   * Decide whether or not should hide sign in guide.

[calamity, 2016/07/21 04:56:49]

* Hides the signin guide when the user is already signed in or in a guest
session.

[lshang, 2016/07/21 07:09:55]

Done.

+   * @param {boolean} signInState
+   * @return {boolean}
+   */
+  hideSignInGuide: function(signInState) {

[calamity, 2016/07/21 04:56:49]

Maybe make this 'showSignInGuide' and invert everything. That would be
consistent with showNoSyncedMessage above.

[lshang, 2016/07/21 07:09:55]

Done. Yeah I was also thinking of this, this is probably better:-)

+    return signInState || this.guestSession_;
+  },
+
+  /**
    * Decide what message should be displayed when user is logged in and there
    * are no synced tabs.
    * @param {boolean} fetchingSyncedTabs
    * @return {string}
    */
   noSyncedTabsMessage: function(fetchingSyncedTabs) {
     return loadTimeData.getString(
         fetchingSyncedTabs ? 'loading' : 'noSyncedResults');
   },
 
@@ skipping 50 matching lines @@
     // User signed in, show the loading message when querying for synced
     // devices.
     this.fetchingSyncedTabs_ = true;
   },
 
   searchTermChanged: function(searchedTerm) {
     this.clearDisplayedSyncedDevices_();
     this.updateSyncedDevices(this.sessionList);
   }
 });