Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2171513003: Re-enable canvas optimization for getImageData with new codepath (Closed)

Created:
4 years, 5 months ago by Justin Novosad
Modified:
4 years, 5 months ago
Reviewers:
xidachen, xlai (Olivia)
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, haraken, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable canvas optimization for getImageData with new codepath This change re-enables the optimization that makes canvases switch out of gpu-acceleration when getImageData is called. The old implementation was scrapped in favor of the new ImageBuffer::disableAcceleration method that was introduced by https://crrev.com/98739b054a5b28cc607d688b2e9e582456bbb20e BUG=606688 Committed: https://crrev.com/e56410217e3d336d0c2d1dbc442180aefba935c5 Cr-Commit-Position: refs/heads/master@{#406950}

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -39 lines) Patch
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +1 line, -28 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsTypes.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 1 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Justin Novosad
PTAL
4 years, 5 months ago (2016-07-20 19:31:26 UTC) #2
xidachen
lgtm
4 years, 5 months ago (2016-07-20 20:22:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171513003/1
4 years, 5 months ago (2016-07-20 20:45:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/266091)
4 years, 5 months ago (2016-07-20 22:22:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171513003/20001
4 years, 5 months ago (2016-07-21 18:15:55 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 21:24:52 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 21:28:00 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e56410217e3d336d0c2d1dbc442180aefba935c5
Cr-Commit-Position: refs/heads/master@{#406950}

Powered by Google App Engine
This is Rietveld 408576698