Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: content/public/test/layouttest_support.h

Issue 2171503005: Rename WebTestProxy to WebViewTestProxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/layouttest_support.h
diff --git a/content/public/test/layouttest_support.h b/content/public/test/layouttest_support.h
index ea3460a52e68cc1de663b3286670c7f18b99bf04..e86b60c614499293a1dffadc81e794d881d60109 100644
--- a/content/public/test/layouttest_support.h
+++ b/content/public/test/layouttest_support.h
@@ -34,7 +34,7 @@ class BluetoothAdapter;
namespace test_runner {
class WebFrameTestProxyBase;
-class WebTestProxyBase;
+class WebViewTestProxyBase;
}
namespace content {
@@ -53,25 +53,27 @@ void EnableBrowserLayoutTestMode();
// Turn a renderer into layout test mode.
void EnableRendererLayoutTestMode();
-// "Casts" |render_view| to |WebTestProxyBase|. Caller has to ensure that prior
-// to construction of |render_view|, EnableWebTestProxyCreation was called.
-test_runner::WebTestProxyBase* GetWebTestProxyBase(RenderView* render_view);
+// "Casts" |render_view| to |WebViewTestProxyBase|. Caller has to ensure that
+// prior to construction of |render_view|, EnableWebViewTestProxyCreation was
+// called.
+test_runner::WebViewTestProxyBase* GetWebViewTestProxyBase(
+ RenderView* render_view);
// "Casts" |render_frame| to |WebFrameTestProxyBase|. Caller has to ensure
-// that prior to construction of |render_frame|, EnableWebTestProxyCreation was
-// called.
+// that prior to construction of |render_frame|, EnableWebViewTestProxyCreation
+// was called.
test_runner::WebFrameTestProxyBase* GetWebFrameTestProxyBase(
RenderFrame* render_frame);
-// Enable injecting of a WebTestProxy between WebViews and RenderViews
+// Enable injecting of a WebViewTestProxy between WebViews and RenderViews
// and WebFrameTestProxy between WebFrames and RenderFrames.
-// |view_proxy_creation_callback| is invoked after creating WebTestProxy.
+// |view_proxy_creation_callback| is invoked after creating WebViewTestProxy.
// |frame_proxy_creation_callback| is called after creating WebFrameTestProxy.
using ViewProxyCreationCallback =
- base::Callback<void(RenderView*, test_runner::WebTestProxyBase*)>;
+ base::Callback<void(RenderView*, test_runner::WebViewTestProxyBase*)>;
using FrameProxyCreationCallback =
base::Callback<void(RenderFrame*, test_runner::WebFrameTestProxyBase*)>;
-void EnableWebTestProxyCreation(
+void EnableWebViewTestProxyCreation(
Łukasz Anforowicz 2016/07/21 19:14:50 Not sure if "View" is necessary above (as this fun
lfg 2016/07/22 04:24:50 Done.
const ViewProxyCreationCallback& view_proxy_creation_callback,
const FrameProxyCreationCallback& frame_proxy_creation_callback);

Powered by Google App Engine
This is Rietveld 408576698