Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2171503004: [Merge M-53] Parameterize OnError method. (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge M-53] Parameterize OnError method. This change is required to support following part of the spec. "Let acceptedMethods be supportedMethods with all identifiers removed that the user agent does not accept. If the length of acceptedMethods is zero, then reject acceptPromise with a NotSupportedError." BUG=627705 Review-Url: https://codereview.chromium.org/2145553002 Cr-Commit-Position: refs/heads/master@{#406227} (cherry picked from commit e542d0af7a4908ec043b86d858bb9206a1c9c7f9) Committed: https://chromium.googlesource.com/chromium/src/+/699aeaa333c549a032a24b7505576d71f501e22b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -29 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/data/android/payments/contact_details.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/android/payments/dynamic_shipping.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/android/payments/email.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/android/payments/free_shipping.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/android/payments/no_shipping.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/android/payments/phone.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 3 chunks +45 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp View 4 chunks +31 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp View 2 chunks +19 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/payments/payment_request.mojom View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
please use gerrit instead
4 years, 5 months ago (2016-07-21 17:36:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
699aeaa333c549a032a24b7505576d71f501e22b.

Powered by Google App Engine
This is Rietveld 408576698