chrome/browser/push_messaging/push_messaging_service_impl.cc - Issue 2171503003: Remove remaining occurences of CONTENT_SETTINGS_TYPE_PUSH_MESSAGING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_service_impl.cc

Issue 2171503003: Remove remaining occurences of CONTENT_SETTINGS_TYPE_PUSH_MESSAGING (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-push-content-setting-2

Patch Set: Remove remaining occurences of CONTENT_SETTINGS_TYPE_PUSH_MESSAGING Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_util.cc ('k') | chrome/browser/push_messaging/push_messaging_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_service_impl.cc

diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.cc b/chrome/browser/push_messaging/push_messaging_service_impl.cc

index b2de8fdec907d6b997916705a7440de6029bfc88..be99393c915b9cefab6a2bc653428370e315db84 100644

--- a/chrome/browser/push_messaging/push_messaging_service_impl.cc

+++ b/chrome/browser/push_messaging/push_messaging_service_impl.cc

@@ -683,10 +683,8 @@ void PushMessagingServiceImpl::OnContentSettingChanged(

const ContentSettingsPattern& secondary_pattern,

ContentSettingsType content_type,

std::string resource_identifier) {

- if (content_type != CONTENT_SETTINGS_TYPE_PUSH_MESSAGING &&

- content_type != CONTENT_SETTINGS_TYPE_NOTIFICATIONS) {

+ if (content_type != CONTENT_SETTINGS_TYPE_NOTIFICATIONS)

return;

- }

std::vector<PushMessagingAppIdentifier> all_app_identifiers =

PushMessagingAppIdentifier::GetAll(profile_);

« no previous file with comments | « chrome/browser/permissions/permission_util.cc ('k') | chrome/browser/push_messaging/push_messaging_service_unittest.cc » ('j') | no next file with comments »