components/content_settings/core/common/content_settings.cc - Issue 2171503003: Remove remaining occurences of CONTENT_SETTINGS_TYPE_PUSH_MESSAGING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/common/content_settings.cc

Issue 2171503003: Remove remaining occurences of CONTENT_SETTINGS_TYPE_PUSH_MESSAGING (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-push-content-setting-2

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_registry.cc ('k') | components/content_settings/core/common/content_settings_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/common/content_settings.cc

diff --git a/components/content_settings/core/common/content_settings.cc b/components/content_settings/core/common/content_settings.cc

index e7a8dea8fb8ec22b5cf3d3140d5f3b24377e21b2..d1adaa31a46c834a222d2b11286d24ea3f3d02a1 100644

--- a/components/content_settings/core/common/content_settings.cc

+++ b/components/content_settings/core/common/content_settings.cc

@@ -41,7 +41,7 @@ ContentSettingsType kHistogramOrder[] = {

CONTENT_SETTINGS_TYPE_PPAPI_BROKER,

CONTENT_SETTINGS_TYPE_AUTOMATIC_DOWNLOADS,

CONTENT_SETTINGS_TYPE_MIDI_SYSEX,

- CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,

+ CONTENT_SETTINGS_TYPE_DEFAULT,

tsergeant 2016/07/21 04:57:29 Nit: Add a comment like the other removed items

raymes 2016/07/25 01:48:24 Done.

CONTENT_SETTINGS_TYPE_SSL_CERT_DECISIONS,

CONTENT_SETTINGS_TYPE_DEFAULT, // METRO_SWITCH_TO_DESKTOP (deprecated).

#if defined(OS_ANDROID) || defined(OS_CHROMEOS)