Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2171503003: Remove remaining occurences of CONTENT_SETTINGS_TYPE_PUSH_MESSAGING (Closed)

Created:
4 years, 5 months ago by raymes
Modified:
4 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, msramek+watch_chromium.org, michaelpg+watch-options_chromium.org, Peter Beverloo, johnme+watch_chromium.org, raymes+watch_chromium.org, mlamouri+watch-permissions_chromium.org, markusheintz_, harkness+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-push-content-setting-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remaining occurences of CONTENT_SETTINGS_TYPE_PUSH_MESSAGING Occurences can either by safely changed to CONTENT_SETTINGS_TYPE_NOTIFICATIONS or are removed (as often they had no purpose to begin with). BUG=628058 Committed: https://crrev.com/516a7db6e16ec0eb7bb0c505c738e1a8c2627fe6 Cr-Commit-Position: refs/heads/master@{#409147}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove remaining occurences of CONTENT_SETTINGS_TYPE_PUSH_MESSAGING #

Patch Set 3 : Remove remaining occurences of CONTENT_SETTINGS_TYPE_PUSH_MESSAGING #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -46 lines) Patch
M chrome/browser/permissions/permission_context_base_unittest.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/permissions/permission_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/permissions/permission_manager_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/permissions/permission_util.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/site_settings_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_default_provider.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/content_settings/core/browser/content_settings_registry.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M components/content_settings/core/common/content_settings.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/common/content_settings_types.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
raymes
4 years, 5 months ago (2016-07-21 02:03:33 UTC) #2
tsergeant
I didn't realise this was happening. Yay, lgtm! (with one nit) https://codereview.chromium.org/2171503003/diff/1/components/content_settings/core/common/content_settings.cc File components/content_settings/core/common/content_settings.cc (right): ...
4 years, 5 months ago (2016-07-21 04:57:29 UTC) #3
raymes
https://codereview.chromium.org/2171503003/diff/1/components/content_settings/core/common/content_settings.cc File components/content_settings/core/common/content_settings.cc (right): https://codereview.chromium.org/2171503003/diff/1/components/content_settings/core/common/content_settings.cc#newcode44 components/content_settings/core/common/content_settings.cc:44: CONTENT_SETTINGS_TYPE_DEFAULT, On 2016/07/21 04:57:29, tsergeant wrote: > Nit: Add ...
4 years, 5 months ago (2016-07-25 01:48:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171503003/40001
4 years, 5 months ago (2016-07-25 01:48:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/224021)
4 years, 5 months ago (2016-07-25 01:54:22 UTC) #9
raymes
+OWNERS peter: chrome/browser/push_messaging/push_messaging_service_impl.cc chrome/browser/push_messaging/push_messaging_service_unittest.cc dbeam: chrome/browser/ui/webui/options/content_settings_handler.cc chrome/browser/ui/webui/site_settings_helper.cc
4 years, 4 months ago (2016-08-02 01:43:20 UTC) #11
Peter Beverloo
lgtm
4 years, 4 months ago (2016-08-02 01:56:07 UTC) #12
Dan Beam
rs lgtm
4 years, 4 months ago (2016-08-02 05:46:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171503003/40001
4 years, 4 months ago (2016-08-02 06:04:15 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-02 06:43:46 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 06:45:20 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/516a7db6e16ec0eb7bb0c505c738e1a8c2627fe6
Cr-Commit-Position: refs/heads/master@{#409147}

Powered by Google App Engine
This is Rietveld 408576698