third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 683101cec9c7be27f3dfb42418bf43128124e880..575fd6d01ed1187d75b7dd02eb6a1c13e0e035e0 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -1377,7 +1377,7 @@ Node* WebViewImpl::bestTapNode(const GestureEventWithHitTestResults& targetedTap

}

// Editable nodes should not be highlighted (e.g., <input>)

- if (bestTouchNode->hasEditableStyle())

+ if (hasEditableStyle(*bestTouchNode))

return nullptr;

Node* cursorDefiningAncestor =

« third_party/WebKit/Source/core/dom/Node.cpp ('K') | « third_party/WebKit/Source/modules/accessibility/AXTable.cpp ('k') | no next file » | no next file with comments »