third_party/WebKit/Source/core/layout/LayoutButton.h - Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutButton.h

Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Node.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutButton.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutButton.h b/third_party/WebKit/Source/core/layout/LayoutButton.h

index 2c6b97f151c2803b41cbd38d6e2d3d594924b3e8..685b0925f8b5401cdd93eb7b831b4f82067bb851 100644

--- a/third_party/WebKit/Source/core/layout/LayoutButton.h

+++ b/third_party/WebKit/Source/core/layout/LayoutButton.h

@@ -37,7 +37,7 @@ public:

const char* name() const override { return "LayoutButton"; }

bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectLayoutButton || LayoutFlexibleBox::isOfType(type); }

- bool canBeSelectionLeaf() const override { return node() && node()->hasEditableStyle(); }

+ bool canBeSelectionLeaf() const override { return node() && hasEditableStyle(*node()); }

void addChild(LayoutObject* newChild, LayoutObject *beforeChild = nullptr) override;

void removeChild(LayoutObject*) override;