third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp - Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Node.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/WrapContentsInDummySpanCommand.cpp ('k') | third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

index 120089a0f1f65c5da1b328a786a7f2f8ed2bee30..1e28221286f28f72b4702c77d040ec9511163921 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

@@ -419,7 +419,7 @@ bool SpellChecker::markMisspellingsOrBadGrammar(const VisibleSelection& selectio

// If we're not in an editable node, bail.

Node* editableNode = range.startPosition().computeContainerNode();

- if (!editableNode || !editableNode->hasEditableStyle())

+ if (!editableNode || !hasEditableStyle(*editableNode))

return false;

if (!isSpellCheckingEnabledFor(editableNode))

@@ -487,7 +487,7 @@ void SpellChecker::markAllMisspellingsAndBadGrammarInRanges(TextCheckingTypeMask

// If we're not in an editable node, bail.

Node* editableNode = spellingRange.startPosition().computeContainerNode();

- if (!editableNode || !editableNode->hasEditableStyle())

+ if (!editableNode || !hasEditableStyle(*editableNode))

return;

if (!isSpellCheckingEnabledFor(editableNode))