third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp - Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp

Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Node.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/WrapContentsInDummySpanCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp b/third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp

index 6bfa30124805f13066fc89e166e864deefcf8a92..e299d36796eb4ad1bd92955225d2877182718492 100644

--- a/third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp

@@ -47,7 +47,7 @@ void SplitTextNodeContainingElementCommand::doApply(EditingState*)

splitTextNode(m_text.get(), m_offset);

Element* parent = m_text->parentElement();

- if (!parent || !parent->parentElement() || !parent->parentElement()->hasEditableStyle())

+ if (!parent || !parent->parentElement() || !hasEditableStyle(*parent->parentElement()))

return;

LayoutObject* parentLayoutObject = parent->layoutObject();