third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp - Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Node.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

index a518d6e37f3c305fadbac3ce2639f0a86b47a746..9a9580962f26b032a6fba7e7adc21fb30c6fa6bb 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

@@ -50,7 +50,7 @@ void InsertIntoTextNodeCommand::doApply(EditingState*)

if (passwordEchoEnabled)

document().updateStyleAndLayoutIgnorePendingStylesheets();

- if (!m_node->hasEditableStyle())

+ if (!hasEditableStyle(*m_node))

return;

if (passwordEchoEnabled) {

@@ -65,7 +65,7 @@ void InsertIntoTextNodeCommand::doApply(EditingState*)

void InsertIntoTextNodeCommand::doUnapply()

{

- if (!m_node->hasEditableStyle())

+ if (!hasEditableStyle(*m_node))

return;

m_node->deleteData(m_offset, m_text.length(), IGNORE_EXCEPTION);