third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp - Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Node.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp b/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

index 44442099edb41aee29f75bb55e3d68f0f039a3c0..504bd7c0de5f4f6b4dd85b64a8823e3878f6440e 100644

--- a/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

@@ -165,14 +165,14 @@ Node* enclosingBlockToSplitTreeTo(Node* startNode)

DCHECK(startNode);

Node* lastBlock = startNode;

for (Node& runner : NodeTraversal::inclusiveAncestorsOf(*startNode)) {

- if (!runner.hasEditableStyle())

+ if (!hasEditableStyle(runner))

return lastBlock;

- if (isTableCell(&runner) || isHTMLBodyElement(&runner) || !runner.parentNode() || !runner.parentNode()->hasEditableStyle() || isElementForFormatBlock(&runner))

+ if (isTableCell(&runner) || isHTMLBodyElement(&runner) || !runner.parentNode() || !hasEditableStyle(*runner.parentNode()) || isElementForFormatBlock(&runner))

return &runner;

if (isEnclosingBlock(&runner))

lastBlock = &runner;

if (isHTMLListElement(&runner))

- return runner.parentNode()->hasEditableStyle() ? runner.parentNode() : &runner;

+ return hasEditableStyle(*runner.parentNode()) ? runner.parentNode() : &runner;

}

return lastBlock;

}