Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXTable.cpp

Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 if (!m_layoutObject || !getNode()) 103 if (!m_layoutObject || !getNode())
104 return false; 104 return false;
105 105
106 // Do not consider it a data table if it has an ARIA role. 106 // Do not consider it a data table if it has an ARIA role.
107 if (hasARIARole()) 107 if (hasARIARole())
108 return false; 108 return false;
109 109
110 // When a section of the document is contentEditable, all tables should be 110 // When a section of the document is contentEditable, all tables should be
111 // treated as data tables, otherwise users may not be able to work with rich 111 // treated as data tables, otherwise users may not be able to work with rich
112 // text editors that allow creating and editing tables. 112 // text editors that allow creating and editing tables.
113 if (getNode() && getNode()->hasEditableStyle()) 113 if (getNode() && hasEditableStyle(*getNode()))
114 return true; 114 return true;
115 115
116 // This employs a heuristic to determine if this table should appear. 116 // This employs a heuristic to determine if this table should appear.
117 // Only "data" tables should be exposed as tables. 117 // Only "data" tables should be exposed as tables.
118 // Unfortunately, there is no good way to determine the difference 118 // Unfortunately, there is no good way to determine the difference
119 // between a "layout" table and a "data" table. 119 // between a "layout" table and a "data" table.
120 120
121 LayoutTable* table = toLayoutTable(m_layoutObject); 121 LayoutTable* table = toLayoutTable(m_layoutObject);
122 Node* tableNode = table->node(); 122 Node* tableNode = table->node();
123 if (!isHTMLTableElement(tableNode)) 123 if (!isHTMLTableElement(tableNode))
(...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after
563 563
564 DEFINE_TRACE(AXTable) 564 DEFINE_TRACE(AXTable)
565 { 565 {
566 visitor->trace(m_rows); 566 visitor->trace(m_rows);
567 visitor->trace(m_columns); 567 visitor->trace(m_columns);
568 visitor->trace(m_headerContainer); 568 visitor->trace(m_headerContainer);
569 AXLayoutObject::trace(visitor); 569 AXLayoutObject::trace(visitor);
570 } 570 }
571 571
572 } // namespace blink 572 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698