[Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions.

third_party/WebKit/Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 579 matching lines @@
         return false;
 
     // FIXME(dmazzoni): support ScopedAXObjectCache (crbug/489851).
     if (AXObjectCache* cache = node.document().existingAXObjectCache())
         return cache->rootAXEditableElement(&node);
 
     return false;
 }
 
 // TODO(yoichio): Move to core/editing
-bool Node::hasEditableStyle(EditableType editableType) const
+bool hasEditableStyle(const Node& node, EditableType editableType)
 {
     switch (editableType) {
     case ContentIsEditable:
-        return blink::hasEditableStyle(*this, Editable);
+        return blink::hasEditableStyle(node, Editable);
     case HasEditableAXRole:
-        return isEditableToAccessibility(*this, Editable);
+        return isEditableToAccessibility(node, Editable);
     }
     NOTREACHED();
     return false;
 }
 
 // TODO(yoichio): Move to core/editing
-bool Node::layoutObjectIsRichlyEditable(EditableType editableType) const
+bool layoutObjectIsRichlyEditable(const Node& node, EditableType editableType)

[tkent, 2016/07/21 09:26:40]

Off topic: The names 'hasEditableStyle' and 'layoutObjectIsRichlyEditable' are
inconsistent.  Let's rename them later.
Off topic: It seems we can remove EditableType argument.  Let's remove it later.

 {
     switch (editableType) {
     case ContentIsEditable:
-        return blink::hasEditableStyle(*this, RichlyEditable);
+        return blink::hasEditableStyle(node, RichlyEditable);
     case HasEditableAXRole:
-        return isEditableToAccessibility(*this, RichlyEditable);
+        return isEditableToAccessibility(node, RichlyEditable);
     }
     NOTREACHED();
     return false;
 }
 
 LayoutBox* Node::layoutBox() const
 {
     LayoutObject* layoutObject = this->layoutObject();
     return layoutObject && layoutObject->isBox() ? toLayoutBox(layoutObject) : nullptr;
 }
@@ skipping 376 matching lines @@
     return 0;
 }
 
 // FIXME: Shouldn't these functions be in the editing code?  Code that asks questions about HTML in the core DOM class
 // is obviously misplaced.
 bool Node::canStartSelection() const
 {
     if (isDisabledFormControl(this))
         return false;
 
-    if (hasEditableStyle())
+    if (hasEditableStyle(*this))
         return true;
 
     if (layoutObject()) {
         const ComputedStyle& style = layoutObject()->styleRef();
         // We allow selections to begin within an element that has -webkit-user-select: none set,
         // but if the element is draggable then dragging should take priority over selection.
         if (style.userDrag() == DRAG_ELEMENT && style.userSelect() == SELECT_NONE)
             return false;
     }
     ContainerNode* parent = FlatTreeTraversal::parent(*this);
@@ skipping 108 matching lines @@
 ContainerNode* Node::parentOrShadowHostOrTemplateHostNode() const
 {
     if (isDocumentFragment() && toDocumentFragment(this)->isTemplateContent())
         return static_cast<const TemplateContentDocumentFragment*>(this)->host();
     return parentOrShadowHostNode();
 }
 
 // TODO(yoichio): Move to core/editing
 bool isRootEditableElement(const Node& node)
 {
-    return node.hasEditableStyle() && node.isElementNode() && (!node.parentNode() || !node.parentNode()->hasEditableStyle()
+    return hasEditableStyle(node) && node.isElementNode() && (!node.parentNode() || !hasEditableStyle(*node.parentNode())
         || !node.parentNode()->isElementNode() || &node == node.document().body());
 }
 
 // TODO(yoichio): Move to core/editing
 Element* rootEditableElement(const Node& node, EditableType editableType)
 {
     if (editableType == HasEditableAXRole) {
         if (AXObjectCache* cache = node.document().existingAXObjectCache())
             return const_cast<Element*>(cache->rootAXEditableElement(&node));
     }
 
     return rootEditableElement(node);
 }
 
 // TODO(yoichio): Move to core/editing
 Element* rootEditableElement(const Node& node)
 {
     const Node* result = nullptr;
-    for (const Node* n = &node; n && n->hasEditableStyle(); n = n->parentNode()) {
+    for (const Node* n = &node; n && hasEditableStyle(*n); n = n->parentNode()) {
         if (n->isElementNode())
             result = n;
         if (node.document().body() == n)
             break;
     }
     return toElement(const_cast<Node*>(result));
 }
 
 // FIXME: End of obviously misplaced HTML editing functions.  Try to move these out of Node.
 
@@ skipping 475 matching lines @@
         WTFLogAlways("%s?%s\t%p\n", prefix, nodeName().utf8().data(), this);
     } else if (isShadowRoot()) {
         // nodeName of ShadowRoot is #document-fragment.  It's confused with
         // DocumentFragment.
         WTFLogAlways("%s#shadow-root\t%p\n", prefix, this);
     } else {
         StringBuilder attrs;
         appendAttributeDesc(this, attrs, idAttr, " ID");
         appendAttributeDesc(this, attrs, classAttr, " CLASS");
         appendAttributeDesc(this, attrs, styleAttr, " STYLE");
-        if (hasEditableStyle())
+        if (hasEditableStyle(*this))
             attrs.append(" (editable)");
         if (document().focusedElement() == this)
             attrs.append(" (focused)");
         WTFLogAlways("%s%s\t%p%s\n", prefix, nodeName().utf8().data(), this, attrs.toString().utf8().data());
     }
 }
 
 void Node::showTreeForThis() const
 {
     showTreeAndMark(this, "*");
@@ skipping 865 matching lines @@
 
 void showNodePath(const blink::Node* node)
 {
     if (node)
         node->showNodePathForThis();
     else
         fprintf(stderr, "Cannot showNodePath for (nil)\n");
 }
 
 #endif