Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2171493002: Moves ToastManager from Shell to WmShell (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, sadrul, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves ToastManager from Shell to WmShell BUG=612331 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/004dce53fdc0eabb8c4413a74ee854a686621299 Cr-Commit-Position: refs/heads/master@{#406673}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M ash/accelerators/debug_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm_shell.h View 4 chunks +6 lines, -0 lines 0 comments Download
M ash/common/wm_shell.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell.h View 3 chunks +0 lines, -5 lines 0 comments Download
M ash/shell.cc View 3 chunks +1 line, -5 lines 0 comments Download
M ash/system/toast/toast_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/arc/notification/arc_notification_manager.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
sky
4 years, 5 months ago (2016-07-20 18:24:44 UTC) #1
James Cook
LGTM with nit https://codereview.chromium.org/2171493002/diff/1/ui/arc/notification/arc_notification_manager.cc File ui/arc/notification/arc_notification_manager.cc (right): https://codereview.chromium.org/2171493002/diff/1/ui/arc/notification/arc_notification_manager.cc#newcode9 ui/arc/notification/arc_notification_manager.cc:9: #include "ash/shell.h" not needed?
4 years, 5 months ago (2016-07-20 20:31:41 UTC) #6
sky
https://codereview.chromium.org/2171493002/diff/1/ui/arc/notification/arc_notification_manager.cc File ui/arc/notification/arc_notification_manager.cc (right): https://codereview.chromium.org/2171493002/diff/1/ui/arc/notification/arc_notification_manager.cc#newcode9 ui/arc/notification/arc_notification_manager.cc:9: #include "ash/shell.h" On 2016/07/20 20:31:40, James Cook wrote: > ...
4 years, 5 months ago (2016-07-20 20:38:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171493002/20001
4 years, 5 months ago (2016-07-20 20:39:29 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 21:28:41 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 21:32:18 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/004dce53fdc0eabb8c4413a74ee854a686621299
Cr-Commit-Position: refs/heads/master@{#406673}

Powered by Google App Engine
This is Rietveld 408576698