Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2171463002: [Android] Enable platform mode for perf tests on Galaxy S5 (Closed)

Created:
4 years, 5 months ago by rnephew (Reviews Here)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Enable platform mode for perf tests on Galaxy S5 BUG=615157 Committed: https://chromium.googlesource.com/chromium/tools/build/+/bf806e109ffa60364a3ec9983371555b69b662b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M scripts/slave/recipes/android/perf.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
rnephew (Reviews Here)
There was no strong opinion on which bot to start this on, so just picked ...
4 years, 5 months ago (2016-07-20 17:28:44 UTC) #2
jbudorick
lgtm
4 years, 5 months ago (2016-07-20 17:45:08 UTC) #3
rnephew (Reviews Here)
On 2016/07/20 17:45:08, jbudorick wrote: > lgtm Im going to hold off on commiting until ...
4 years, 5 months ago (2016-07-20 17:46:01 UTC) #4
jbudorick
On 2016/07/20 17:46:01, rnephew (Reviews Here) wrote: > On 2016/07/20 17:45:08, jbudorick wrote: > > ...
4 years, 5 months ago (2016-07-20 17:47:46 UTC) #5
dtu
lgtm
4 years, 5 months ago (2016-07-20 21:36:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171463002/1
4 years, 5 months ago (2016-07-20 21:37:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/bf806e109ffa60364a3ec9983371555b69b662b4
4 years, 5 months ago (2016-07-20 21:42:15 UTC) #10
jbudorick
4 years, 5 months ago (2016-07-20 22:53:31 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2172463002/ by jbudorick@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/chromium.perf/builders/Android%20Galaxy%20S5%20P....

Powered by Google App Engine
This is Rietveld 408576698