Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2171443003: In TextInputManager, reset input type to none before switching active widgets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing kenrb@'s comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 34b8ff6150519975b06cc16b19e7dc48b4945912..60e6b8c8e7cbebdcee4e85ffb7591d5ae982abba 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -2978,6 +2978,12 @@ void RenderWidgetHostViewAura::OnUpdateTextInputStateCalled(
bool did_update_state) {
DCHECK_EQ(text_input_manager_, text_input_manager);
+ // We only process updates from the active widget as the ones from other views
+ // are due to late arriving IPCs which are no longer needed.
+ if (GetTextInputManager()->GetActiveWidget() !=
+ updated_view->GetRenderWidgetHost())
EhsanK 2016/07/27 16:17:44 The intention for adding this logic was to make su
+ return;
+
if (!GetInputMethod())
return;

Powered by Google App Engine
This is Rietveld 408576698