content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 2171443003: In TextInputManager, reset input type to none before switching active widgets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2171443003: In TextInputManager, reset input type to none before switching active widgets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed a typo in comment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ('k') | content/browser/renderer_host/text_input_manager.cc » ('j') | content/browser/renderer_host/text_input_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index 34b8ff6150519975b06cc16b19e7dc48b4945912..60e6b8c8e7cbebdcee4e85ffb7591d5ae982abba 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -2978,6 +2978,12 @@ void RenderWidgetHostViewAura::OnUpdateTextInputStateCalled(

bool did_update_state) {

DCHECK_EQ(text_input_manager_, text_input_manager);

+ // We only process updates from the active widget as the ones from other views

+ // are due to late arriving IPCs which are no longer needed.

+ if (GetTextInputManager()->GetActiveWidget() !=

+ updated_view->GetRenderWidgetHost())

+ return;

if (!GetInputMethod())

return;