Deprecate the CallbackSubscription in BrowsingDataRemover

Deprecate the CallbackSubscription in BrowsingDataRemover

BrowsingDataRemover currently supports two notification systems:
1. BrowsingDataRemover::Observer
2. BrowsingDataRemover::CallbackSubscription

Remove #2 in favor of #1.

The NotificationDetails class which is returned by #2, and used by tests to
determine the parameters of the last call to BrowsingDataRemover, is replaced
by a public API of BrowsingDataRemover exposing the same values.

The consolidation of notifications will simplify the implementation of task
scheduler for removal tasks, as described in
https://docs.google.com/document/d/1oIbmZJlq5m5FvHcN7trCpp0h4mtydA0UfZasxEIe3P8/

BUG=630327
Committed: https://crrev.com/00117ff9b264b662930f8e10683fe2a0f7abef3f
Cr-Commit-Position: refs/heads/master@{#408378}

[msramek, 2016-07-22 16:37:55]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 16:38:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 17:48:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 17:48:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msramek, 2016-07-22 18:03:29]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 18:03:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-07-22 18:47:47]

Description was changed from

==========
Deprecate the CallbackSubscription in BrowsingDataRemover

BrowsingDataRemover currently supports two notification systems:
1. BrowsingDataRemover::Observer
2. BrowsingDataRemover::CallbackSubscription


The NotificationDetails class which is returned by #2, and used by tests to
determine the parameters of the last call to BrowsingDataRemover, is replaced
by a public API of BrowsingDataRemover exposing the same values.

The consolidation of notifications will simplify the implementation of task
scheduler for removal tasks, as described in
https://docs.google.com/document/d/1oIbmZJlq5m5FvHcN7trCpp0h4mtydA0UfZasxEIe3P8/

BUG=630327
==========

to

==========
Deprecate the CallbackSubscription in BrowsingDataRemover

BrowsingDataRemover currently supports two notification systems:
1. BrowsingDataRemover::Observer
2. BrowsingDataRemover::CallbackSubscription

Remove #2 in favor of #1.

The NotificationDetails class which is returned by #2, and used by tests to
determine the parameters of the last call to BrowsingDataRemover, is replaced
by a public API of BrowsingDataRemover exposing the same values.

The consolidation of notifications will simplify the implementation of task
scheduler for removal tasks, as described in
https://docs.google.com/document/d/1oIbmZJlq5m5FvHcN7trCpp0h4mtydA0UfZasxEIe3P8/

BUG=630327
==========

[msramek, 2016-07-22 18:50:23]

msramek@chromium.org changed reviewers:
+ mkwst@chromium.org

[msramek, 2016-07-22 18:50:23]

Hi Mike,

Please have a look! (Not on Friday evening of course, I'm just publishing this
so that it appears in your queue :) )

Thanks,
Martin

[commit-bot: I haz the power, 2016-07-22 21:11:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 21:11:57]

Dry run: This issue passed the CQ dry run.

[msramek, 2016-07-28 11:58:12]

Friendly ping :)

[Mike West, 2016-07-28 12:02:22]

https://codereview.chromium.org/2171383002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/browsing_data/browsing_data_test.cc (right):

https://codereview.chromium.org/2171383002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/browsing_data/browsing_data_test.cc:266:
EXPECT_EQ(0, GetRemovalMask());
Why did this change?

[msramek, 2016-07-28 12:20:04]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 12:20:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-07-28 12:20:49]

https://codereview.chromium.org/2171383002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/browsing_data/browsing_data_test.cc (right):

https://codereview.chromium.org/2171383002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/browsing_data/browsing_data_test.cc:266:
EXPECT_EQ(0, GetRemovalMask());
On 2016/07/28 12:02:22, Mike West wrote:
> Why did this change?

Previously, "no notification received yet" was represented by an empty instance
of BrowsingDataRemover::NotificationDetails; NotificationDetails initializes all
masks to -1.

BrowsingDataRemover doesn't do that, so the stored masks are implicitly
initialized to 0 (until the first Remove() call sets it to some real value).

But I guess someone could potentially call Remove() with an empty mask, so we
can do the same there.

[Mike West, 2016-07-28 12:32:37]

On 2016/07/28 at 12:20:49, msramek wrote:
> But I guess someone could potentially call Remove() with an empty mask, so we
can do the same there.

LGTM. Thanks! :)

[msramek, 2016-07-28 12:35:42]

The CQ bit was unchecked by msramek@chromium.org

[msramek, 2016-07-28 12:35:49]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2016-07-28 12:36:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 12:58:18]

Description was changed from

==========
Deprecate the CallbackSubscription in BrowsingDataRemover

BrowsingDataRemover currently supports two notification systems:
1. BrowsingDataRemover::Observer
2. BrowsingDataRemover::CallbackSubscription

Remove #2 in favor of #1.

The NotificationDetails class which is returned by #2, and used by tests to
determine the parameters of the last call to BrowsingDataRemover, is replaced
by a public API of BrowsingDataRemover exposing the same values.

The consolidation of notifications will simplify the implementation of task
scheduler for removal tasks, as described in
https://docs.google.com/document/d/1oIbmZJlq5m5FvHcN7trCpp0h4mtydA0UfZasxEIe3P8/

BUG=630327
==========

to

==========
Deprecate the CallbackSubscription in BrowsingDataRemover

BrowsingDataRemover currently supports two notification systems:
1. BrowsingDataRemover::Observer
2. BrowsingDataRemover::CallbackSubscription

Remove #2 in favor of #1.

The NotificationDetails class which is returned by #2, and used by tests to
determine the parameters of the last call to BrowsingDataRemover, is replaced
by a public API of BrowsingDataRemover exposing the same values.

The consolidation of notifications will simplify the implementation of task
scheduler for removal tasks, as described in
https://docs.google.com/document/d/1oIbmZJlq5m5FvHcN7trCpp0h4mtydA0UfZasxEIe3P8/

BUG=630327
==========

[commit-bot: I haz the power, 2016-07-28 12:58:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-28 12:59:48]

Description was changed from

==========
Deprecate the CallbackSubscription in BrowsingDataRemover

BrowsingDataRemover currently supports two notification systems:
1. BrowsingDataRemover::Observer
2. BrowsingDataRemover::CallbackSubscription

Remove #2 in favor of #1.

The NotificationDetails class which is returned by #2, and used by tests to
determine the parameters of the last call to BrowsingDataRemover, is replaced
by a public API of BrowsingDataRemover exposing the same values.

The consolidation of notifications will simplify the implementation of task
scheduler for removal tasks, as described in
https://docs.google.com/document/d/1oIbmZJlq5m5FvHcN7trCpp0h4mtydA0UfZasxEIe3P8/

BUG=630327
==========

to

==========
Deprecate the CallbackSubscription in BrowsingDataRemover

BrowsingDataRemover currently supports two notification systems:
1. BrowsingDataRemover::Observer
2. BrowsingDataRemover::CallbackSubscription

Remove #2 in favor of #1.

The NotificationDetails class which is returned by #2, and used by tests to
determine the parameters of the last call to BrowsingDataRemover, is replaced
by a public API of BrowsingDataRemover exposing the same values.

The consolidation of notifications will simplify the implementation of task
scheduler for removal tasks, as described in
https://docs.google.com/document/d/1oIbmZJlq5m5FvHcN7trCpp0h4mtydA0UfZasxEIe3P8/

BUG=630327

Committed: https://crrev.com/00117ff9b264b662930f8e10683fe2a0f7abef3f
Cr-Commit-Position: refs/heads/master@{#408378}
==========

[commit-bot: I haz the power, 2016-07-28 12:59:49]

Patchset 3 (id:??) landed as
https://crrev.com/00117ff9b264b662930f8e10683fe2a0f7abef3f
Cr-Commit-Position: refs/heads/master@{#408378}