Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2171373003: AnimationGroup for groups of transitions in Settings (Closed)

Created:
4 years, 5 months ago by michaelpg
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AnimationGroup for groups of transitions in Settings Adds settings.animation.AnimationGroup for playing a Promise-based set of animation(s). Used in https://crrev.com/2106013002 to create standalone transitions rather than scattering animation code throughout other classes. BUG=589681 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/48e079d573d6385fab6ad7110475a2b9da913bab Cr-Commit-Position: refs/heads/master@{#407510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
A + chrome/browser/resources/settings/animation/animation_group.html View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/resources/settings/animation/animation_group.js View 1 chunk +49 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/animation/compiled_resources2.gyp View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/animation_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
michaelpg
yeah, PTAL
4 years, 5 months ago (2016-07-23 00:52:53 UTC) #2
Dan Beam
lgtm
4 years, 5 months ago (2016-07-23 00:53:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171373003/1
4 years, 5 months ago (2016-07-23 00:53:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171373003/1
4 years, 5 months ago (2016-07-25 16:57:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 17:57:58 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 18:01:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48e079d573d6385fab6ad7110475a2b9da913bab
Cr-Commit-Position: refs/heads/master@{#407510}

Powered by Google App Engine
This is Rietveld 408576698