Fix remoting dependency.

Fix remoting dependency.

BUG=357715
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260462

[Sergey Ulanov, 2014-03-28 19:44:05]

thanks for fixing it! LGTM after my comment is addressed.

https://codereview.chromium.org/217133007/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://codereview.chromium.org/217133007/diff/1/remoting/remoting.gyp#newcod...
remoting/remoting.gyp:263: '../base/base.gyp:base_i18n',
I think this dependency should be added in remoting_host, not remoting_base

[Avi (use Gerrit), 2014-03-28 20:58:01]

https://codereview.chromium.org/217133007/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://codereview.chromium.org/217133007/diff/1/remoting/remoting.gyp#newcod...
remoting/remoting.gyp:263: '../base/base.gyp:base_i18n',
On 2014/03/28 19:44:06, Sergey Ulanov wrote:
> I think this dependency should be added in remoting_host, not remoting_base

Done.

[Avi (use Gerrit), 2014-03-28 21:00:18]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-03-28 21:02:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/217133007/20001

[commit-bot: I haz the power, 2014-03-28 23:45:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 23:45:23]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[Sergey Ulanov, 2014-03-28 23:46:30]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-03-28 23:50:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/217133007/20001

[commit-bot: I haz the power, 2014-03-29 01:24:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-29 01:24:47]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Avi (use Gerrit), 2014-03-29 01:33:56]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-03-29 01:34:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/217133007/20001

[commit-bot: I haz the power, 2014-03-29 03:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-29 03:10:55]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Avi (use Gerrit), 2014-03-29 03:21:24]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-03-29 03:23:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/217133007/20001

[commit-bot: I haz the power, 2014-03-29 05:00:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-29 05:00:57]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Avi (use Gerrit), 2014-03-30 17:19:36]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-03-30 17:21:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/217133007/20001

[commit-bot: I haz the power, 2014-03-30 20:41:34]

Change committed as 260462