AppCache error details tests

AppCache error details tests

Follows Blink (crrev.com/164873003) and Chromium (crrev.com/164933002)

BUG=342555
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170621

[jsbell, 2014-03-28 16:03:05]

michaeln@ - these are just the tests split out from http://crrev.com/164873003 -
can you R?

[michaeln, 2014-03-31 20:18:43]

lgtm

https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
File LayoutTests/http/tests/appcache/modified-manifest.html (right):

https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
LayoutTests/http/tests/appcache/modified-manifest.html:7: function
unexpectedEvent(name)
not used?

https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
File LayoutTests/http/tests/appcache/resources/modified-manifest.php (right):

https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
LayoutTests/http/tests/appcache/resources/modified-manifest.php:6: # is not
byte-for-byte identical, which will cause caching to tail.
typo: tail s/b fail

https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
File LayoutTests/http/tests/appcache/wrong-signature-2.html (right):

https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
LayoutTests/http/tests/appcache/wrong-signature-2.html:31:
applicationCache.addEventListener('noupdate', function() { log("noupdate");
cacheCallback() }, false);
looks like the intent is to replace cacheCallback() replace with the new
unexpectedEvent() function

[jsbell, 2014-03-31 20:25:48]

On 2014/03/31 20:18:43, michaeln wrote:
> lgtm
> 
>
https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
> File LayoutTests/http/tests/appcache/modified-manifest.html (right):
> 
>
https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
> LayoutTests/http/tests/appcache/modified-manifest.html:7: function
> unexpectedEvent(name)
> not used?
> 
>
https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
> File LayoutTests/http/tests/appcache/resources/modified-manifest.php (right):
> 
>
https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
> LayoutTests/http/tests/appcache/resources/modified-manifest.php:6: # is not
> byte-for-byte identical, which will cause caching to tail.
> typo: tail s/b fail
> 
>
https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
> File LayoutTests/http/tests/appcache/wrong-signature-2.html (right):
> 
>
https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
> LayoutTests/http/tests/appcache/wrong-signature-2.html:31:
> applicationCache.addEventListener('noupdate', function() { log("noupdate");
> cacheCallback() }, false);
> looks like the intent is to replace cacheCallback() replace with the new
> unexpectedEvent() function

Thanks. I'm actually going to roll a change for crbug.com/358293 into this, and
local testing appears to be reporting a failure - my guess it's a rebase/merge
glitch on the chromium side where a response code isn't getting set. So expect a
re-up and re-review request shortly.

[jsbell, 2014-03-31 22:10:45]

New patch. Addresses review feedback, and also some uses of log() in error
handlers that was no longer defined. Also removes some the redundant "'url' in
event" assertions when the value of 'url' is subsequently tested.

The failing test was indeed a merge glitch on the chromium side (yay tests!) -
new patch uploaded there and landing.

I also made the 'status' -> 'statusCode' switch.

https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
File LayoutTests/http/tests/appcache/modified-manifest.html (right):

https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
LayoutTests/http/tests/appcache/modified-manifest.html:7: function
unexpectedEvent(name)
On 2014/03/31 20:18:43, michaeln wrote:
> not used?

Removed.

https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
File LayoutTests/http/tests/appcache/resources/modified-manifest.php (right):

https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
LayoutTests/http/tests/appcache/resources/modified-manifest.php:6: # is not
byte-for-byte identical, which will cause caching to tail.
On 2014/03/31 20:18:43, michaeln wrote:
> typo: tail s/b fail

Done.

https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
File LayoutTests/http/tests/appcache/wrong-signature-2.html (right):

https://codereview.chromium.org/217133002/diff/20001/LayoutTests/http/tests/a...
LayoutTests/http/tests/appcache/wrong-signature-2.html:31:
applicationCache.addEventListener('noupdate', function() { log("noupdate");
cacheCallback() }, false);
On 2014/03/31 20:18:43, michaeln wrote:
> looks like the intent is to replace cacheCallback() replace with the new
> unexpectedEvent() function

Done.

[jsbell, 2014-03-31 22:11:58]

darin@ - can you review the Event changes (renaming `status` to `statusCode`)
per crbug.com/358293 ?

[jsbell, 2014-04-01 21:04:08]

Ugh, this time with darin@ actually on the reviewers list.

darin@ - can you review the Event changes (renaming `status` to `statusCode`)
per crbug.com/358293 ?

[jsbell, 2014-04-02 00:19:52]

On 2014/04/01 21:04:08, jsbell wrote:
> Ugh, this time with darin@ actually on the reviewers list.
> 
> darin@ - can you review the Event changes (renaming `status` to `statusCode`)
> per crbug.com/358293 ?

Actually, cancel that. I'm going to revert back to 'status' since that's what
XMLHttpRequest has and it's what engendered no objections. So this ends up being
just tests that michael has already reviewed.

[jsbell, 2014-04-02 00:20:16]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-04-02 00:20:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/217133002/80001

[commit-bot: I haz the power, 2014-04-02 01:28:59]

Change committed as 170621