Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2171323002: Introduce a holder for compile jobs (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce a holder for compile jobs Next step will be to add methods for parsing and then compiling. BUG=v8:5215 R=marja@chromium.org Committed: https://crrev.com/b5b9dd730a52e20cdc4a122b4e6a56c4f5290533 Cr-Commit-Position: refs/heads/master@{#37980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/compiler-dispatcher/compiler-dispatcher-job.h View 1 chunk +41 lines, -0 lines 0 comments Download
A src/compiler-dispatcher/compiler-dispatcher-job.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-22 11:53:37 UTC) #1
marja
lgtm
4 years, 5 months ago (2016-07-22 11:59:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171323002/1
4 years, 5 months ago (2016-07-22 12:03:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 12:19:54 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 12:22:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5b9dd730a52e20cdc4a122b4e6a56c4f5290533
Cr-Commit-Position: refs/heads/master@{#37980}

Powered by Google App Engine
This is Rietveld 408576698