Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2171313003: Enable renegotiate tests. (Closed)

Created:
4 years, 5 months ago by ehmaldonado_chromium
Modified:
4 years, 5 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, jam, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable renegotiate tests. The tests CanMakeAudioCallAndThenRenegotiateToVideo and CanMakeVideoCallAndThenRenegotiateToAudio had been disabled because of a bug in libjingle/webrtc. These tests run fine in my machine. It might have been fixed by now. BUG=484826 Committed: https://crrev.com/f62387805b09fbee97a64d207ddc7ee8d3c7e085 Cr-Commit-Position: refs/heads/master@{#407146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M content/browser/media/webrtc/webrtc_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/media/webrtc/webrtc_browsertest_audio.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
ehmaldonado_chromium
These tests run fine on my machine.
4 years, 5 months ago (2016-07-22 11:48:21 UTC) #1
ehmaldonado_chromium
4 years, 5 months ago (2016-07-22 11:48:35 UTC) #3
phoglund_chromium
lgtm, but note the bug claimed they were flaky so you need to keep an ...
4 years, 5 months ago (2016-07-22 11:57:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171313003/1
4 years, 5 months ago (2016-07-22 13:04:37 UTC) #8
ehmaldonado_chromium
On 2016/07/22 11:57:30, phoglund_chrome wrote: > lgtm, but note the bug claimed they were flaky ...
4 years, 5 months ago (2016-07-22 13:04:49 UTC) #9
ehmaldonado_chromium
On 2016/07/22 11:57:30, phoglund_chrome wrote: > lgtm, but note the bug claimed they were flaky ...
4 years, 5 months ago (2016-07-22 13:04:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 13:43:42 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f62387805b09fbee97a64d207ddc7ee8d3c7e085 Cr-Commit-Position: refs/heads/master@{#407146}
4 years, 5 months ago (2016-07-22 13:45:59 UTC) #14
phoglund_chromium
4 years, 5 months ago (2016-07-22 13:51:10 UTC) #15
Message was sent while issue was closed.
On 2016/07/22 13:04:52, ehmaldonado_chromium wrote:
> On 2016/07/22 11:57:30, phoglund_chrome wrote:
> > lgtm, but note the bug claimed they were flaky so you need to keep an eye on
> > these tests for a few days and turn them back off again if the fail flakily.
> 
> A fail would reflect in the waterfall, or how should I keep track of it?

Yes. On, say, Monday, go through the build history for a few WebRTC Chromium
bots. If you see content_browsertests failures every now and then, check the
logs. If this test is in there its still flaky.

Powered by Google App Engine
This is Rietveld 408576698