Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2171303005: Disable flaky MetricsWebContentsObserverBrowserTests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 6 #include "base/test/histogram_tester.h"
7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
9 #include "chrome/common/url_constants.h" 9 #include "chrome/common/url_constants.h"
10 #include "chrome/test/base/in_process_browser_test.h" 10 #include "chrome/test/base/in_process_browser_test.h"
(...skipping 17 matching lines...) Expand all
28 28
29 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NoNavigation) { 29 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NoNavigation) {
30 ASSERT_TRUE(embedded_test_server()->Start()); 30 ASSERT_TRUE(embedded_test_server()->Start());
31 31
32 histogram_tester_.ExpectTotalCount(internal::kHistogramCommit, 0); 32 histogram_tester_.ExpectTotalCount(internal::kHistogramCommit, 0);
33 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 0); 33 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 0);
34 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 0); 34 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 0);
35 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 0); 35 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 0);
36 } 36 }
37 37
38 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NewPage) { 38 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
39 DISABLED_NewPage) {
39 ASSERT_TRUE(embedded_test_server()->Start()); 40 ASSERT_TRUE(embedded_test_server()->Start());
40 41
41 ui_test_utils::NavigateToURL(browser(), 42 ui_test_utils::NavigateToURL(browser(),
42 embedded_test_server()->GetURL("/title1.html")); 43 embedded_test_server()->GetURL("/title1.html"));
43 NavigateToUntrackedUrl(); 44 NavigateToUntrackedUrl();
44 45
45 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1); 46 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);
46 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1); 47 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1);
47 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1); 48 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1);
48 histogram_tester_.ExpectTotalCount(internal::kHistogramParseDuration, 1); 49 histogram_tester_.ExpectTotalCount(internal::kHistogramParseDuration, 1);
49 histogram_tester_.ExpectTotalCount( 50 histogram_tester_.ExpectTotalCount(
50 internal::kHistogramParseBlockedOnScriptLoad, 1); 51 internal::kHistogramParseBlockedOnScriptLoad, 1);
51 } 52 }
52 53
53 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, 54 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
54 SamePageNavigation) { 55 DISABLED_SamePageNavigation) {
55 ASSERT_TRUE(embedded_test_server()->Start()); 56 ASSERT_TRUE(embedded_test_server()->Start());
56 57
57 ui_test_utils::NavigateToURL(browser(), 58 ui_test_utils::NavigateToURL(browser(),
58 embedded_test_server()->GetURL("/title1.html")); 59 embedded_test_server()->GetURL("/title1.html"));
59 ui_test_utils::NavigateToURL( 60 ui_test_utils::NavigateToURL(
60 browser(), embedded_test_server()->GetURL("/title1.html#hash")); 61 browser(), embedded_test_server()->GetURL("/title1.html#hash"));
61 NavigateToUntrackedUrl(); 62 NavigateToUntrackedUrl();
62 63
63 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1); 64 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);
64 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1); 65 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1);
65 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1); 66 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1);
66 } 67 }
67 68
68 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, 69 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
69 SameUrlNavigation) { 70 DISABLED_SameUrlNavigation) {
70 ASSERT_TRUE(embedded_test_server()->Start()); 71 ASSERT_TRUE(embedded_test_server()->Start());
71 72
72 ui_test_utils::NavigateToURL(browser(), 73 ui_test_utils::NavigateToURL(browser(),
73 embedded_test_server()->GetURL("/title1.html")); 74 embedded_test_server()->GetURL("/title1.html"));
74 ui_test_utils::NavigateToURL(browser(), 75 ui_test_utils::NavigateToURL(browser(),
75 embedded_test_server()->GetURL("/title1.html")); 76 embedded_test_server()->GetURL("/title1.html"));
76 NavigateToUntrackedUrl(); 77 NavigateToUntrackedUrl();
77 78
78 // We expect one histogram sample for each navigation to title1.html. 79 // We expect one histogram sample for each navigation to title1.html.
79 histogram_tester_.ExpectTotalCount(internal::kHistogramCommit, 2); 80 histogram_tester_.ExpectTotalCount(internal::kHistogramCommit, 2);
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 ASSERT_TRUE(embedded_test_server()->Start()); 215 ASSERT_TRUE(embedded_test_server()->Start());
215 216
216 ui_test_utils::NavigateToURL( 217 ui_test_utils::NavigateToURL(
217 browser(), embedded_test_server()->GetURL( 218 browser(), embedded_test_server()->GetURL(
218 "/page_load_metrics/document_write_no_script.html")); 219 "/page_load_metrics/document_write_no_script.html"));
219 NavigateToUntrackedUrl(); 220 NavigateToUntrackedUrl();
220 221
221 histogram_tester_.ExpectTotalCount( 222 histogram_tester_.ExpectTotalCount(
222 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0); 223 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
223 } 224 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698