MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double arrays.'

MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double arrays.'

Port 6470ddadf93594657acee02b5ce5459752928490

On MIPS different signaling NaN values must be used for hardware and simulator targets, even at snapshot generation when always simulator is used.

Original commit message:
This introduces SilenceNaN operator, which makes sure that we only
store quiet NaNs into holey arrays. We omit the NaN silencing code
at instruction selection time if the input is an operation that
cannot possibly produce signalling NaNs.

BUG=

Committed: https://crrev.com/52f2ceb052f63324050c7a098e4398f510b54763
Cr-Commit-Position: refs/heads/master@{#38030}

[balazs.kilvady, 2016-07-22 11:09:59]

balazs.kilvady@imgtec.com changed reviewers:
+ akos.palfi@mattakis.com, ilija.pavlovic.imgtec@gmail.com,
ivica.bogosavljevic@imgtec.com, jarin@chromium.org, machenbach@google.com,
marija.antic@imgtec.com

[balazs.kilvady, 2016-07-22 11:09:59]

PTAL. We need lgtm from v8 developer team.

[balazs.kilvady, 2016-07-22 11:10:01]

PTAL. We need lgtm from v8 developer team.

[akos.palfi.imgtec, 2016-07-22 14:41:29]

akos.palfi@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com

[akos.palfi.imgtec, 2016-07-22 14:41:29]

Lgtm

[balazs.kilvady, 2016-07-22 17:47:30]

The CQ bit was checked by balazs.kilvady@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 17:47:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 18:12:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 18:12:13]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-07-25 13:11:01]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-07-25 13:11:01]

lgtm

[balazs.kilvady, 2016-07-25 15:46:45]

The CQ bit was checked by balazs.kilvady@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 15:46:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 16:18:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 16:18:39]

Dry run: This issue passed the CQ dry run.

[balazs.kilvady, 2016-07-25 17:26:12]

The CQ bit was checked by balazs.kilvady@imgtec.com

[balazs.kilvady, 2016-07-25 17:26:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org, akos.palfi@imgtec.com
Link to the patchset: https://codereview.chromium.org/2171303002/#ps20001
(title: "Add mac cross-build conditions.")

[commit-bot: I haz the power, 2016-07-25 17:26:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 17:27:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-25 17:29:46]

Description was changed from

==========
MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double arrays.'

Port 6470ddadf93594657acee02b5ce5459752928490

On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.

Original commit message:
This introduces SilenceNaN operator, which makes sure that we only
store quiet NaNs into holey arrays. We omit the NaN silencing code
at instruction selection time if the input is an operation that
cannot possibly produce signalling NaNs.

BUG=
==========

to

==========
MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double arrays.'

Port 6470ddadf93594657acee02b5ce5459752928490

On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.

Original commit message:
This introduces SilenceNaN operator, which makes sure that we only
store quiet NaNs into holey arrays. We omit the NaN silencing code
at instruction selection time if the input is an operation that
cannot possibly produce signalling NaNs.

BUG=

Committed: https://crrev.com/52f2ceb052f63324050c7a098e4398f510b54763
Cr-Commit-Position: refs/heads/master@{#38030}
==========

[commit-bot: I haz the power, 2016-07-25 17:29:47]

Patchset 2 (id:??) landed as
https://crrev.com/52f2ceb052f63324050c7a098e4398f510b54763
Cr-Commit-Position: refs/heads/master@{#38030}

[benwells, 2016-07-26 04:44:45]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2184573002/ by benwells@chromium.org.

The reason for reverting is: This bug has an error in the toolchain.gypi file,
the conditions clause is repeated. This has broken the DrMemory builder - see
first failing chromium build
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%...
which included a v8 roll.

For reference the errors are:
gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\d8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\v8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\samples\samples.gyp
.

[Michael Achenbach, 2016-07-26 06:32:29]

https://codereview.chromium.org/2171303002/diff/20001/gypfiles/toolchain.gypi
File gypfiles/toolchain.gypi (right):

https://codereview.chromium.org/2171303002/diff/20001/gypfiles/toolchain.gypi...
gypfiles/toolchain.gypi:374: 'conditions': [
These leftover conditions led to the drmemory errors on chromium.

[balazs.kilvady, 2016-07-26 15:58:23]

https://codereview.chromium.org/2171303002/diff/20001/gypfiles/toolchain.gypi
File gypfiles/toolchain.gypi (right):

https://codereview.chromium.org/2171303002/diff/20001/gypfiles/toolchain.gypi...
gypfiles/toolchain.gypi:374: 'conditions': [
On 2016/07/26 06:32:29, Michael Achenbach (slow) wrote:
> These leftover conditions led to the drmemory errors on chromium.

Thanks for catching it, I am going to upload a new CL with the fix.

[Michael Achenbach, 2016-07-26 15:59:59]

On 2016/07/26 15:58:23, balazs.kilvady wrote:
> https://codereview.chromium.org/2171303002/diff/20001/gypfiles/toolchain.gypi
> File gypfiles/toolchain.gypi (right):
> 
>
https://codereview.chromium.org/2171303002/diff/20001/gypfiles/toolchain.gypi...
> gypfiles/toolchain.gypi:374: 'conditions': [
> On 2016/07/26 06:32:29, Michael Achenbach (slow) wrote:
> > These leftover conditions led to the drmemory errors on chromium.
> 
> Thanks for catching it, I am going to upload a new CL with the fix.

As you wish. You can also repurpose this CL if you want.