Remove asserts on scissor size in Vulkan

src/gpu/vk/GrVkPipeline.cpp

 /*
 * Copyright 2016 Google Inc.
 *
 * Use of this source code is governed by a BSD-style license that can be
 * found in the LICENSE file.
 */
 
 #include "GrVkPipeline.h"
 
 #include "GrGeometryProcessor.h"
@@ skipping 488 matching lines @@
         scissor.extent.width = scissorState.rect().width();
         if (kTopLeft_GrSurfaceOrigin == target.origin()) {
             scissor.offset.y = scissorState.rect().fTop;
         } else {
             SkASSERT(kBottomLeft_GrSurfaceOrigin == target.origin());
             scissor.offset.y = target.height() - scissorState.rect().fBottom;
         }
         scissor.extent.height = scissorState.rect().height();
 
         SkASSERT(scissor.offset.x >= 0);
-        SkASSERT(scissor.offset.x + scissor.extent.width <= (uint32_t)target.width());
         SkASSERT(scissor.offset.y >= 0);
-        SkASSERT(scissor.offset.y + scissor.extent.height <= (uint32_t)target.height());

[csmartdalton, 2016/07/22 20:54:48]

Ah, looks my change gave you grief. I also removed a similar assert in GL:

https://codereview.chromium.org/2160093002/diff/140001/src/gpu/gl/GrGLIRect.h

In GL, the only requirement is that width and height are non-negative. Should we
also remove the asserts that x,y >= 0? (I'd be surprised if vulkan allowed you
to overstep the right edge, but not the left.)

     } else {
         scissor.extent.width = target.width();
         scissor.extent.height = target.height();
         scissor.offset.x = 0;
         scissor.offset.y = 0;
     }
     cmdBuffer->setScissor(gpu, 0, 1, &scissor);
 }
 
 void set_dynamic_viewport_state(GrVkGpu* gpu,
@@ skipping 27 matching lines @@
 }
 
 void GrVkPipeline::SetDynamicState(GrVkGpu* gpu,
                                    GrVkCommandBuffer* cmdBuffer,
                                    const GrPipeline& pipeline) {
     const GrRenderTarget& target = *pipeline.getRenderTarget();
     set_dynamic_scissor_state(gpu, cmdBuffer, pipeline, target);
     set_dynamic_viewport_state(gpu, cmdBuffer, target);
     set_dynamic_blend_constant_state(gpu, cmdBuffer, pipeline);
 }