Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2171273002: Revert of Roll buildtools 55638fe5c3..60f7f9a8b4 (Closed)

Created:
4 years, 5 months ago by msramek
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll buildtools 55638fe5c3..60f7f9a8b4 (patchset #1 id:1 of https://codereview.chromium.org/2166993002/ ) Reason for revert: Speculative revert - this probably broke the official build - see crbug.com/630514 for more details. Will reland if the suspicion was wrong. Original issue's description: > Roll buildtools 55638fe5c3..60f7f9a8b4 > > In order to roll GN af92718f55..1f41736051 (r405547:r406705) and pick up > the following changes: > > 267b1de Make `gn refs` handle files in data directories properly. > 5fc3faf Add TaskPriority as a parameter to SequencedWorkerPool in preparation for TaskScheduler experiment. > aca0875 Make `gn refs` look at script files. > 05316e0 Re-land r406064 "[GN] Add JSON project writer". > 5a1b4b1 Revert of [GN] Add JSON project writer (patchset #11 id:200001 of https://codereview.chromium.org/2064533002/ ) > d2edeb9 [GN] Add JSON project writer > f0544fc Remove calls to MessageLoop::current() in tools. > d93e5cf Document GN invoker and target name variables. > > TBR=dpranke@chromium.org > > Committed: https://crrev.com/d8a18dc3820a4d54d8fc9ad8667d242798f10d33 > Cr-Commit-Position: refs/heads/master@{#406727} TBR=dpranke@chromium.org,brettw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/de249eccb4145727c8eee6ecb737bd50cbbf844e Cr-Commit-Position: refs/heads/master@{#407125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
msramek
Created Revert of Roll buildtools 55638fe5c3..60f7f9a8b4
4 years, 5 months ago (2016-07-22 09:29:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171273002/1
4 years, 5 months ago (2016-07-22 09:30:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 10:24:08 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/de249eccb4145727c8eee6ecb737bd50cbbf844e Cr-Commit-Position: refs/heads/master@{#407125}
4 years, 5 months ago (2016-07-22 10:25:44 UTC) #6
brettw
You reverted a GN roll for a GYP bot?
4 years, 5 months ago (2016-07-22 17:32:27 UTC) #7
brettw
On 2016/07/22 17:32:27, brettw (ping on IM after 24h) wrote: > You reverted a GN ...
4 years, 5 months ago (2016-07-22 17:36:19 UTC) #8
brettw
4 years, 5 months ago (2016-07-22 17:36:32 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2172323002/ by brettw@chromium.org.

The reason for reverting is: GN binaries will not affects GYP's errors about
conditions..

Powered by Google App Engine
This is Rietveld 408576698