[gn] Migrate more custom cflags from gyp to gn

[gn] Migrate more custom cflags from gyp to gn

BUG=chromium:474921
Committed: https://crrev.com/a4dbaf1c0cd7ec0dce512585294d933ae324c875
Cr-Commit-Position: refs/heads/master@{#38000}

[Michael Achenbach, 2016-07-22 09:27:53]

Description was changed from

==========
[gn] Migrate more custom cflags from gyp to gn

BUG=
==========

to

==========
[gn] Migrate more custom cflags from gyp to gn

BUG=chromium:474921
==========

[Michael Achenbach, 2016-07-22 09:27:53]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-07-22 09:28:20]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 09:28:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-07-22 09:30:06]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[Michael Achenbach, 2016-07-22 09:30:14]

PTAL

[commit-bot: I haz the power, 2016-07-22 09:30:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vogelheim, 2016-07-22 09:45:25]

lgtm

https://codereview.chromium.org/2171263002/diff/20001/test/cctest/BUILD.gn
File test/cctest/BUILD.gn (right):

https://codereview.chromium.org/2171263002/diff/20001/test/cctest/BUILD.gn#ne...
test/cctest/BUILD.gn:58: #["OS=="aix"", {
.. Since you now had ldflags, this would trivially fit with your changes below.

https://codereview.chromium.org/2171263002/diff/20001/test/cctest/BUILD.gn#ne...
test/cctest/BUILD.gn:81: v8_current_cpu=="arm" || v8_current_cpu=="arm64" ||
style nitpick: please unify whitespace around the == operator.

[Michael Achenbach, 2016-07-22 09:49:46]

https://codereview.chromium.org/2171263002/diff/20001/test/cctest/BUILD.gn
File test/cctest/BUILD.gn (right):

https://codereview.chromium.org/2171263002/diff/20001/test/cctest/BUILD.gn#ne...
test/cctest/BUILD.gn:58: #["OS=="aix"", {
On 2016/07/22 09:45:25, vogelheim wrote:
> .. Since you now had ldflags, this would trivially fit with your changes
below.

Like to keep it separate as I have no clue about AIX yet.

https://codereview.chromium.org/2171263002/diff/20001/test/cctest/BUILD.gn#ne...
test/cctest/BUILD.gn:81: v8_current_cpu=="arm" || v8_current_cpu=="arm64" ||
On 2016/07/22 09:45:25, vogelheim wrote:
> style nitpick: please unify whitespace around the == operator.

Done.

[Michael Achenbach, 2016-07-25 09:10:23]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-07-25 09:10:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2171263002/#ps60001
(title: "gn format test/cctest/BUILD.gn --in-place")

[commit-bot: I haz the power, 2016-07-25 09:10:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 09:31:47]

Description was changed from

==========
[gn] Migrate more custom cflags from gyp to gn

BUG=chromium:474921
==========

to

==========
[gn] Migrate more custom cflags from gyp to gn

BUG=chromium:474921
==========

[commit-bot: I haz the power, 2016-07-25 09:31:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-25 09:33:51]

Description was changed from

==========
[gn] Migrate more custom cflags from gyp to gn

BUG=chromium:474921
==========

to

==========
[gn] Migrate more custom cflags from gyp to gn

BUG=chromium:474921

Committed: https://crrev.com/a4dbaf1c0cd7ec0dce512585294d933ae324c875
Cr-Commit-Position: refs/heads/master@{#38000}
==========

[commit-bot: I haz the power, 2016-07-25 09:33:52]

Patchset 4 (id:??) landed as
https://crrev.com/a4dbaf1c0cd7ec0dce512585294d933ae324c875
Cr-Commit-Position: refs/heads/master@{#38000}