Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Issue 217123004: Remove V8_INLINE to prevent C4714 warning under Win64. (Closed)

Created:
6 years, 8 months ago by vogelheim
Modified:
6 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove V8_INLINE to prevent C4714 warning under Win64. BUG= R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M include/v8-util.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-01 17:34:12 UTC) #1
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-01 18:04:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r20412 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698