Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2171213003: gpu: Keep original GMB alive to workaround problem with importing of UDL/EVDI buffers. (Closed)

Created:
4 years, 5 months ago by reveman
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

gpu: Keep original GMB alive to workaround problem with importing of UDL/EVDI buffers. Destroying the original buffer invalidates kernel state such that importing from the FD doesn't work as expected. By keeping the original buffer alive we avoid this issue for scanout buffers used by the browser process. BUG=628334 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2171713004 Cr-Commit-Position: refs/heads/master@{#406973} (cherry picked from commit 1ff18bae4738ee3d62c2310d9e03211054be0582) Committed: https://chromium.googlesource.com/chromium/src/+/4621081d1ffdc8a9048430f7c3d2e60cc0e309cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.h View 3 chunks +14 lines, -1 line 0 comments Download
M gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
reveman
4 years, 5 months ago (2016-07-22 18:08:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4621081d1ffdc8a9048430f7c3d2e60cc0e309cd.

Powered by Google App Engine
This is Rietveld 408576698